[dpdk-stable] patch 'fix ethdev ports enumeration' has been queued to stable release 18.02.2
Thomas Monjalon
thomas at monjalon.net
Mon Apr 30 17:07:37 CEST 2018
30/04/2018 16:41, luca.boccassi at gmail.com:
> Hi,
>
> FYI, your patch has been queued to stable release 18.02.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 05/02/18. So please
> shout if anyone has objections.
I did not plan to backport it. But yes, it may be a good idead.
In this case, you need to backport some fixes on top of it:
net/mvpp2: fix build
ethdev: remove experimental flag of ports enumeration
> ---
> From beef7e18559abf272f9ca0a4d1b62f8d32c47b02 Mon Sep 17 00:00:00 2001
> From: Thomas Monjalon <thomas at monjalon.net>
> Date: Thu, 5 Apr 2018 17:33:20 +0200
> Subject: [PATCH] fix ethdev ports enumeration
>
> [ upstream commit 8728ccf37615904cf23fb8763895b05c9a3c6b0c ]
>
> Some DPDK applications wrongly assume these requirements:
> - no hotplug, i.e. ports are never detached
> - all allocated ports are available to the application
>
> Such application iterates over ports by its own mean.
> The most common pattern is to request the port count and
> assume ports with index in the range [0..count[ can be used.
>
> There are three consequences when using such wrong design:
> - new ports having an index higher than the port count won't be seen
> - old ports being detached (RTE_ETH_DEV_UNUSED) can be seen as ghosts
> - failsafe sub-devices (RTE_ETH_DEV_DEFERRED) will be seen by the application
>
> Such mistake will be less common with growing hotplug awareness.
> All applications and examples inside this repository - except testpmd -
> must be fixed to use the iterator RTE_ETH_FOREACH_DEV.
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
More information about the stable
mailing list