[dpdk-stable] [PATCH 16.11] net/enic: do not overwrite admin Tx queue limit
Luca Boccassi
bluca at debian.org
Fri Aug 3 11:05:31 CEST 2018
On Thu, 2018-08-02 at 21:33 -0700, Hyong Youb Kim wrote:
> [ backported from upstream commit
> 2a7e3d54659cd12d337ad816dcf202eec1af1367 ]
>
> Currently, enic_alloc_wq (via rte_eth_tx_queue_setup) may overwrite
> the admin limit with a lower value. This is wrong as seen in the
> following sequence.
>
> 1. UCS admin-set Tx queue limit (config.wq_desc_count) = 4096
> 2. Set up tx queue with 512 descriptors
> The admin limit (config.wq_desc_count) becomes 512.
> 3. Stop ports and now set up Tx queue with 1024 descriptors.
> This fails because 1024 is greater than the admin limit (512).
>
> Do not modify the admin limit, and when queried, report the current
> number of descriptors instead of the admin limit. The rx queue setup
> (enic_alloc_rq) does not this problem.
>
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
> Reviewed-by: John Daley <johndale at cisco.com>
> ---
> drivers/net/enic/enic_main.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
Thanks, applied and pushed to dpdk-stable/16.11.
--
Kind regards,
Luca Boccassi
More information about the stable
mailing list