[dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter

Yongseok Koh yskoh at mellanox.com
Thu Aug 16 20:59:24 CEST 2018


rte_errno may have garbage value if there's no error.

Fixes: 7075f007b361 ("net/mlx5: standardize on negative errno values")
Fixes: 8e47ba2b073a ("net/mlx5: fix error number handling")

Signed-off-by: Yongseok Koh <yskoh at mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 7e4b84292..7e69f6aba 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -3001,9 +3001,11 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev,
 		if (parser.queue[i].ibv_attr)
 			rte_free(parser.queue[i].ibv_attr);
 	}
-	if (ret)
+	if (ret) {
 		rte_errno = ret; /* Restore rte_errno. */
-	return -rte_errno;
+		return -rte_errno;
+	}
+	return 0;
 }
 
 /**
-- 
2.11.0



More information about the stable mailing list