[dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and ihl

[Rami Rosen]

Hi Saleh,
Thanks for your patch.
If you will grep into the DPDK repo you will see that there are several
occurrences of IP_VHL_DEF, with the same functionality.
I would consider putting the IPV4_VHL_DEF you added in a more generic
location and not
under testpmd, so other modules will be able to use it without the need to
include testpmd.h, which is a bit awkard.
Another question is whether it should be IPV4_VHL_DEF or IPV_VHL_DEF as in
other DPDK apps. Probably other apps should be adjusted to use it.

Regards,
Rami Rosen