[dpdk-stable] [PATCH] test: register test as failed if setup failed
Doherty, Declan
declan.doherty at intel.com
Wed Jan 10 15:24:19 CET 2018
On 22/12/2017 10:21 AM, Anatoly Burakov wrote:
> If test set up couldn't be completed, the test was previously
> shown as succeeding, even though setup failed. Fix this to report
> test as failed, and count all tests that should've been executed,
> as failed as well.
>
> Fixes: ffac67b1f71b ("app/test: new assert macros and test suite runner")
> Cc: declan.doherty at intel.com
> Cc: stable at dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> ---
> test/test/test.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/test/test/test.c b/test/test/test.c
> index 0e6ff7c..fe41d40 100644
> --- a/test/test/test.c
> +++ b/test/test/test.c
> @@ -162,8 +162,20 @@ unit_test_suite_runner(struct unit_test_suite *suite)
> }
>
> if (suite->setup)
> - if (suite->setup() != 0)
> + if (suite->setup() != 0) {
> + /*
> + * setup failed, so count all enabled tests and mark
> + * them as failed
> + */
> + while (suite->unit_test_cases[total].testcase) {
> + if (!suite->unit_test_cases[total].enabled)
> + skipped++;
> + else
> + failed++;
> + total++;
> + }
> goto suite_summary;
> + }
>
> printf(" + ------------------------------------------------------- +\n");
>
>
Acked-by: Declan Doherty <declan.doherty at intel.com>
More information about the stable
mailing list