[dpdk-stable] patch 'net/i40e: fix VF reset stats crash' has been queued to LTS release 17.11.1
Yuanhan Liu
yliu at fridaylinux.org
Wed Jan 24 16:32:54 CET 2018
Hi,
FYI, your patch has been queued to LTS release 17.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/26/18. So please
shout if anyone has objections.
Thanks.
--yliu
---
>From 64e3e5117e4e4465e0fca7bba214a660fd66e8d7 Mon Sep 17 00:00:00 2001
From: David Harton <dharton at cisco.com>
Date: Thu, 11 Jan 2018 10:13:58 -0500
Subject: [PATCH] net/i40e: fix VF reset stats crash
[ upstream commit cde1f0252811e81a3c485ca1932cc655736f1e49 ]
Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue
by checking return code before using pstats.
Fixes: 8210e9e0d805 ("net/i40e: fix clear xstats bug in VF")
Signed-off-by: David Harton <dharton at cisco.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Acked-by: Wei Zhao <wei.zhao1 at intel.com>
---
drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 922306f..6160e2f 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -945,14 +945,16 @@ i40evf_update_stats(struct i40e_vsi *vsi,
static void
i40evf_dev_xstats_reset(struct rte_eth_dev *dev)
{
+ int ret;
struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct i40e_eth_stats *pstats = NULL;
/* read stat values to clear hardware registers */
- i40evf_query_stats(dev, &pstats);
+ ret = i40evf_query_stats(dev, &pstats);
/* set stats offset base on current values */
- vf->vsi.eth_stats_offset = *pstats;
+ if (ret == 0)
+ vf->vsi.eth_stats_offset = *pstats;
}
static int i40evf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
--
2.7.4
More information about the stable
mailing list