[dpdk-stable] patch 'test/table: fix uninitialized parameter' has been queued to LTS release 16.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Jan 26 14:13:24 CET 2018
Hi,
FYI, your patch has been queued to LTS release 16.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/28/18. So please
shout if anyone has objections.
Thanks.
Luca Boccassi
---
>From 55fa09034cd9d5f2b8256e0619a279d7afa4fdf4 Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Thu, 21 Dec 2017 15:53:05 +0000
Subject: [PATCH] test/table: fix uninitialized parameter
[ upstream commit 7e60499b6cb941547a147ed66f912aee148ff252 ]
delete_bulk() copies metadata to pointers provided by the entries
parameter, but in the unit test, they are uninitialized, leading
to rte_table attempting to memcpy into random garbage pointers.
Memsetting pointer table to zero will prevent that from happening.
Fixes: 48f2543cf0a8 ("app/test: add bulk adding and deleting")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
app/test/test_table_acl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index b3bfda4cc..a5d44c5b0 100644
--- a/app/test/test_table_acl.c
+++ b/app/test/test_table_acl.c
@@ -532,6 +532,8 @@ setup_acl_pipeline(void)
struct rte_pipeline_table_entry *table_entries[5];
int key_found[5];
+ memset(table_entries, 0, sizeof(table_entries));
+
for (n = 0; n < 5; n++) {
memset(&keys[n], 0, sizeof(struct rte_table_acl_rule_delete_params));
key_array[n] = &keys[n];
--
2.14.2
More information about the stable
mailing list