[dpdk-stable] [PATCH] app/testpmd: fix dcb config failure

Xiaoyun Li xiaoyun.li at intel.com
Tue Jul 24 13:32:34 CEST 2018


After adding RSS hash offload check, default rss_hf will fail on devices
that do not support all bits. This will lead to dcb config failure. The
patch fixes this issue by taking rss_hf as a suggested value and only
setting bits that the device supports based on rte_eth_dev_get_info.

Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
Cc: stable at dpdk.org

Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index f504ca3..d221469 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2575,6 +2575,9 @@ init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+	rte_eth_dev_info_get(pid, &rte_port->dev_info);
+	port_conf.rx_adv_conf.rss_conf.rss_hf &=
+			rte_port->dev_info.flow_type_rss_offloads;
 
 	/* re-configure the device . */
 	rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-- 
2.7.4



More information about the stable mailing list