[dpdk-stable] [PATCH] net/mlx5: fix error number handling
Nélio Laranjeiro
nelio.laranjeiro at 6wind.com
Wed Jun 20 09:05:13 CEST 2018
On Tue, Jun 19, 2018 at 11:00:25PM +0000, Yongseok Koh wrote:
>[...]
> >>> I did not understood it was only a concern about the success of the
> >>> function, even it is better to avoid as most as possible a useless
> >>> store, in this specific case, as errno (rte_errno) has a garbage value,
> >>> I fully agree with you.
> >>
> >> Nelio,
> >>
> >> Do you still want me to make any change for this patch?
> >> Let me know if any.
> >
> > With your modification the function documentation is no more accurate as
> > rte_errno is always set.
>
> I still don't agree with that but will send out v2. It's not a big deal.
What I meant is, you could have only changed the function documentation.
@return
0 on success with rte_errno always set, negative errno otherwise.
letting the function documentation saying rte_errno is only modified in
case of error whereas it is not is a bug or in the documentation or in
the code, but as a function must respect its documentation, it would
have raised a bug in the code itself.
Regards,
--
Nélio Laranjeiro
6WIND
More information about the stable
mailing list