[dpdk-stable] patch 'bus/vdev: fix find device implementation' has been queued to stable release 18.02.2

[Luca Boccassi]

On Wed, 2018-05-02 at 14:16 +0200, Gaëtan Rivet wrote:
> On Wed, May 02, 2018 at 11:57:53AM +0100, Luca Boccassi wrote:
> > On Wed, 2018-05-02 at 10:26 +0200, Gaëtan Rivet wrote:
> > > Hi Luca,
> > > 
> > > On Mon, Apr 30, 2018 at 03:53:21PM +0100, luca.boccassi at gmail.com
> > > wrote:
> > > > Hi,
> > > > 
> > > > FYI, your patch has been queued to stable release 18.02.2
> > > > 
> > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stabl
> > > > e
> > > > yet.
> > > > It will be pushed if I get no objections before 05/02/18. So
> > > > please
> > > > shout if anyone has objections.
> > > 
> > > This patch will be bogus while still compiling in a stable
> > > release,
> > > without the commit: 35f462839b69 ("bus/vdev: add lock on device
> > > list").
> > > 
> > > It should be slightly reworked to function without. The previous
> > > version
> > > of this patch [1] could be used instead.
> > > 
> > > [1]: https://dpdk.org/ml/archives/dev/2018-April/098822.html
> > > 
> > > Regards,
> > 
> > Do you think it's worth including or can I skip it?
> > 
> 
> It is an actual bug with a simple fix, so I think it's worth
> including
> yes.

This is the diff when removing v2 and applying v1 instead:

--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -397,7 +397,7 @@ vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
        }
        while (dev != NULL) {
                if (cmp(&dev->device, data) == 0)
-                       break;
+                       return &dev->device;
                dev = TAILQ_NEXT(dev, next);
        }
        return NULL;


Please let me know if this is correct. Thanks!

-- 
Kind regards,
Luca Boccassi