[dpdk-stable] patch 'igb_uio: remove device reset in open' has been queued to LTS release 16.11.9

[Luca Boccassi]

Hi,

FYI, your patch has been queued to LTS release 16.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/11/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Luca Boccassi

---
>From 278a18a19d7f15aba9c291c6fa7c27e307df976a Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Fri, 20 Oct 2017 17:55:11 +0100
Subject: [PATCH] igb_uio: remove device reset in open

[ upstream commit f73b38e9245d77d4d6b5861f8d203c0bf5120b15 ]

Remove device reset during application start, the reset for application
exit still there.

Reset in open removed because of following comments:
1- Device reset not completed when VF driver loaded, which cause VF PMD
   initialization error.
   Adding delay can solve the issue but will increase driver load time.

2- Reset will be issues all devices unconditionally, not very efficient
   way.

Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Tested-by: Harish Patil <harish.patil at cavium.com>
Tested-by: Shijith Thotton <shijith.thotton at caviumnetworks.com>
Tested-by: Jingjing Wu <jingjing.wu at intel.com>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index 4be89ef86..bedfa6eae 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -179,8 +179,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode)
 	struct rte_uio_pci_dev *udev = info->priv;
 	struct pci_dev *dev = udev->pdev;
 
-	pci_reset_function(dev);
-
 	/* set bus master, which was cleared by the reset function */
 	pci_set_master(dev);
 
-- 
2.19.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-09 14:24:58.312257299 +0000
+++ 0002-igb_uio-remove-device-reset-in-open.patch	2018-11-09 14:24:58.269726115 +0000
@@ -1,8 +1,10 @@
-From f73b38e9245d77d4d6b5861f8d203c0bf5120b15 Mon Sep 17 00:00:00 2001
+From 278a18a19d7f15aba9c291c6fa7c27e307df976a Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Fri, 20 Oct 2017 17:55:11 +0100
 Subject: [PATCH] igb_uio: remove device reset in open
 
+[ upstream commit f73b38e9245d77d4d6b5861f8d203c0bf5120b15 ]
+
 Remove device reset during application start, the reset for application
 exit still there.
 
@@ -15,7 +17,6 @@
    way.
 
 Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Tested-by: Harish Patil <harish.patil at cavium.com>
@@ -26,12 +27,12 @@
  1 file changed, 2 deletions(-)
 
 diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
-index f7ef82554..fd320d87d 100644
+index 4be89ef86..bedfa6eae 100644
 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
 +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
-@@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode)
+@@ -179,8 +179,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode)
+ 	struct rte_uio_pci_dev *udev = info->priv;
  	struct pci_dev *dev = udev->pdev;
- 	int err;
  
 -	pci_reset_function(dev);
 -