[dpdk-stable] patch 'test/reorder: fix out of bound access' has been queued to LTS release 16.11.9

Luca Boccassi bluca at debian.org
Mon Nov 19 13:25:32 CET 2018


Hi,

FYI, your patch has been queued to LTS release 16.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/21/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Luca Boccassi

---
>From ab8f3afb3afe3edc6b253a23fda956144f362b2c Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Tue, 13 Nov 2018 23:31:37 +0000
Subject: [PATCH] test/reorder: fix out of bound access

[ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ]

The value of array index 'i' is out of bound because of the previous
loop it has been used.

Assuming intention is using '0' since the check before free is robufs[0]
check, fixing according.

Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test/test_reorder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_reorder.c b/app/test/test_reorder.c
index add455111..d7dab3210 100644
--- a/app/test/test_reorder.c
+++ b/app/test/test_reorder.c
@@ -300,7 +300,7 @@ test_reorder_drain(void)
 		goto exit;
 	}
 	if (robufs[0] != NULL)
-		rte_pktmbuf_free(robufs[i]);
+		rte_pktmbuf_free(robufs[0]);
 
 	/* Insert more packets
 	 * RB[] = {NULL, NULL, NULL, NULL}
-- 
2.19.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-19 12:15:18.419511907 +0000
+++ 0015-test-reorder-fix-out-of-bound-access.patch	2018-11-19 12:15:18.107611433 +0000
@@ -1,8 +1,10 @@
-From 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f Mon Sep 17 00:00:00 2001
+From ab8f3afb3afe3edc6b253a23fda956144f362b2c Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Tue, 13 Nov 2018 23:31:37 +0000
 Subject: [PATCH] test/reorder: fix out of bound access
 
+[ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ]
+
 The value of array index 'i' is out of bound because of the previous
 loop it has been used.
 
@@ -10,18 +12,17 @@
 check, fixing according.
 
 Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 ---
- test/test/test_reorder.c | 2 +-
+ app/test/test_reorder.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/test/test/test_reorder.c b/test/test/test_reorder.c
-index ccee4d086..58fa9c71b 100644
---- a/test/test/test_reorder.c
-+++ b/test/test/test_reorder.c
-@@ -269,7 +269,7 @@ test_reorder_drain(void)
+diff --git a/app/test/test_reorder.c b/app/test/test_reorder.c
+index add455111..d7dab3210 100644
+--- a/app/test/test_reorder.c
++++ b/app/test/test_reorder.c
+@@ -300,7 +300,7 @@ test_reorder_drain(void)
  		goto exit;
  	}
  	if (robufs[0] != NULL)


More information about the stable mailing list