[dpdk-stable] patch 'net/mlx5: fix artificial L4 limitation on switch flow rules' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Tue Nov 20 20:12:02 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/23/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From 472fb2561be430b32da30a5c29d37a65afd697e9 Mon Sep 17 00:00:00 2001
From: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
Date: Mon, 6 Aug 2018 16:25:42 +0200
Subject: [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules

[ upstream commit dce1e4c2044d0e197eee29182cdb93454a0dc3d5 ]

Partial bit-masks are in fact supported on TCP/UDP source/destination
ports. Remove unnecessary check.

Fixes: 2bfc777e07 ("net/mlx5: add L2-L4 pattern items to switch flow rules")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
---
 drivers/net/mlx5/mlx5_nl_flow.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index a1c8c340b..beb03c911 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -800,14 +800,4 @@ trans:
 		}
 		spec.tcp = item->spec;
-		if ((mask.tcp->hdr.src_port &&
-		     mask.tcp->hdr.src_port != RTE_BE16(0xffff)) ||
-		    (mask.tcp->hdr.dst_port &&
-		     mask.tcp->hdr.dst_port != RTE_BE16(0xffff)))
-			return rte_flow_error_set
-				(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM_MASK,
-				 mask.tcp,
-				 "no support for partial masks on"
-				 " \"hdr.src_port\" and \"hdr.dst_port\""
-				 " fields");
 		if ((mask.tcp->hdr.src_port &&
 		     (!mnl_attr_put_u16_check(buf, size,
@@ -847,14 +837,4 @@ trans:
 		}
 		spec.udp = item->spec;
-		if ((mask.udp->hdr.src_port &&
-		     mask.udp->hdr.src_port != RTE_BE16(0xffff)) ||
-		    (mask.udp->hdr.dst_port &&
-		     mask.udp->hdr.dst_port != RTE_BE16(0xffff)))
-			return rte_flow_error_set
-				(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM_MASK,
-				 mask.udp,
-				 "no support for partial masks on"
-				 " \"hdr.src_port\" and \"hdr.dst_port\""
-				 " fields");
 		if ((mask.udp->hdr.src_port &&
 		     (!mnl_attr_put_u16_check(buf, size,
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-20 17:53:07.753183034 +0000
+++ 0012-net-mlx5-fix-artificial-L4-limitation-on-switch-flow.patch	2018-11-20 17:53:07.000000000 +0000
@@ -1,13 +1,14 @@
-From dce1e4c2044d0e197eee29182cdb93454a0dc3d5 Mon Sep 17 00:00:00 2001
+From 472fb2561be430b32da30a5c29d37a65afd697e9 Mon Sep 17 00:00:00 2001
 From: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
 Date: Mon, 6 Aug 2018 16:25:42 +0200
 Subject: [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules
 
+[ upstream commit dce1e4c2044d0e197eee29182cdb93454a0dc3d5 ]
+
 Partial bit-masks are in fact supported on TCP/UDP source/destination
 ports. Remove unnecessary check.
 
 Fixes: 2bfc777e07 ("net/mlx5: add L2-L4 pattern items to switch flow rules")
-Cc: stable at dpdk.org
 
 Signed-off-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
 ---


More information about the stable mailing list