[dpdk-stable] patch 'net/cxgbe: fix memory access when parsing flow match items' has been queued to stable release 18.08.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/23/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From bee23facb8194fdbbfd08884cc1b0227a69a7ada Mon Sep 17 00:00:00 2001
From: Shagun Agrawal <shaguna at chelsio.com>
Date: Mon, 27 Aug 2018 18:23:31 +0530
Subject: [PATCH] net/cxgbe: fix memory access when parsing flow match items

[ upstream commit 450f99ce7b34cb27f6727cea478292428b328a70 ]

Coverity issue: 293096
Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows")

Signed-off-by: Shagun Agrawal <shaguna at chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
---
 drivers/net/cxgbe/cxgbe_flow.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c
index 01c945f1b..038d479d6 100644
--- a/drivers/net/cxgbe/cxgbe_flow.c
+++ b/drivers/net/cxgbe/cxgbe_flow.c
@@ -455,8 +455,8 @@ cxgbe_rtef_parse_items(struct rte_flow *flow,
 
 	for (i = items; i->type != RTE_FLOW_ITEM_TYPE_END; i++) {
-		struct chrte_fparse *idx = &flow->item_parser[i->type];
+		struct chrte_fparse *idx;
 		int ret;
 
-		if (i->type > ARRAY_SIZE(parseitem))
+		if (i->type >= ARRAY_SIZE(parseitem))
 			return rte_flow_error_set(e, ENOTSUP,
 						  RTE_FLOW_ERROR_TYPE_ITEM,
@@ -479,4 +479,5 @@ cxgbe_rtef_parse_items(struct rte_flow *flow,
 				return ret;
 
+			idx = &flow->item_parser[i->type];
 			if (!idx || !idx->fptr) {
 				return rte_flow_error_set(e, ENOTSUP,
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-20 17:53:07.999631124 +0000
+++ 0022-net-cxgbe-fix-memory-access-when-parsing-flow-match-.patch	2018-11-20 17:53:07.000000000 +0000
@@ -1,11 +1,12 @@
-From 450f99ce7b34cb27f6727cea478292428b328a70 Mon Sep 17 00:00:00 2001
+From bee23facb8194fdbbfd08884cc1b0227a69a7ada Mon Sep 17 00:00:00 2001
 From: Shagun Agrawal <shaguna at chelsio.com>
 Date: Mon, 27 Aug 2018 18:23:31 +0530
 Subject: [PATCH] net/cxgbe: fix memory access when parsing flow match items
 
+[ upstream commit 450f99ce7b34cb27f6727cea478292428b328a70 ]
+
 Coverity issue: 293096
 Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows")
-Cc: stable at dpdk.org
 
 Signed-off-by: Shagun Agrawal <shaguna at chelsio.com>
 Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>