[dpdk-stable] patch 'net/ixgbe: fix missing Tx multi-segs capability' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Wed Nov 21 17:04:13 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From c3b613cdd0f8cc492ff79dd23bb8349e789d7a56 Mon Sep 17 00:00:00 2001
From: Didier Pallard <didier.pallard at 6wind.com>
Date: Wed, 19 Sep 2018 17:04:09 +0200
Subject: [PATCH] net/ixgbe: fix missing Tx multi-segs capability

[ upstream commit e8c220aa9757c1549057bf508416e859aecb31b9 ]

In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating
that application will never send multisegmented packets, allowing
pmd to choose different tx methods accordingly.
In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability
that is advertised by pmds, some of them do not advertise it and
expect to never receive fragmented packets (octeontx, axgbe)
So an ethdev that supports multisegmented packets should properly
advertise it.

Problem was spotted and tested on e1000, should be also present in
ixgbe_vf representor.

Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")

Signed-off-by: Didier Pallard <didier.pallard at 6wind.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
 drivers/net/ixgbe/ixgbe_vf_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_vf_representor.c b/drivers/net/ixgbe/ixgbe_vf_representor.c
index db516d991..b0fbbc49f 100644
--- a/drivers/net/ixgbe/ixgbe_vf_representor.c
+++ b/drivers/net/ixgbe/ixgbe_vf_representor.c
@@ -66,5 +66,5 @@ ixgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
 		DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM |
 		DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_SCTP_CKSUM |
-		DEV_TX_OFFLOAD_TCP_TSO;
+		DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_MULTI_SEGS;
 	/**< Device TX offload capabilities. */
 
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-21 15:59:14.214344916 +0000
+++ 0023-net-ixgbe-fix-missing-Tx-multi-segs-capability.patch	2018-11-21 15:59:13.000000000 +0000
@@ -1,8 +1,10 @@
-From e8c220aa9757c1549057bf508416e859aecb31b9 Mon Sep 17 00:00:00 2001
+From c3b613cdd0f8cc492ff79dd23bb8349e789d7a56 Mon Sep 17 00:00:00 2001
 From: Didier Pallard <didier.pallard at 6wind.com>
 Date: Wed, 19 Sep 2018 17:04:09 +0200
 Subject: [PATCH] net/ixgbe: fix missing Tx multi-segs capability
 
+[ upstream commit e8c220aa9757c1549057bf508416e859aecb31b9 ]
+
 In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating
 that application will never send multisegmented packets, allowing
 pmd to choose different tx methods accordingly.
@@ -16,7 +18,6 @@
 ixgbe_vf representor.
 
 Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
-Cc: stable at dpdk.org
 
 Signed-off-by: Didier Pallard <didier.pallard at 6wind.com>
 Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>


More information about the stable mailing list