[dpdk-stable] patch 'net/enic: fix flow API memory leak' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Wed Nov 21 17:47:46 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/27/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From ce7c316194a4264a8abab5fc2193921710e87e7c Mon Sep 17 00:00:00 2001
From: John Daley <johndale at cisco.com>
Date: Thu, 27 Sep 2018 20:08:36 -0700
Subject: [PATCH] net/enic: fix flow API memory leak

[ upstream commit 85b0ccec381d217ad6fb1698317b863a31fdd8af ]

rte_flow structures were not being freed when destroyed or flushed.

Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")

Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
Signed-off-by: John Daley <johndale at cisco.com>
---
 drivers/net/enic/enic_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index 0cf04aefd..9b612f1d5 100644
--- a/drivers/net/enic/enic_flow.c
+++ b/drivers/net/enic/enic_flow.c
@@ -1533,4 +1533,5 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
 	LIST_REMOVE(flow, next);
 	rte_spinlock_unlock(&enic->flows_lock);
+	rte_free(flow);
 	return 0;
 }
@@ -1556,4 +1557,5 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
 		enic_flow_del_filter(enic, flow->enic_filter_id, error);
 		LIST_REMOVE(flow, next);
+		rte_free(flow);
 	}
 	rte_spinlock_unlock(&enic->flows_lock);
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-21 16:44:31.836726191 +0000
+++ 0032-net-enic-fix-flow-API-memory-leak.patch	2018-11-21 16:44:30.000000000 +0000
@@ -1,12 +1,13 @@
-From 85b0ccec381d217ad6fb1698317b863a31fdd8af Mon Sep 17 00:00:00 2001
+From ce7c316194a4264a8abab5fc2193921710e87e7c Mon Sep 17 00:00:00 2001
 From: John Daley <johndale at cisco.com>
 Date: Thu, 27 Sep 2018 20:08:36 -0700
 Subject: [PATCH] net/enic: fix flow API memory leak
 
+[ upstream commit 85b0ccec381d217ad6fb1698317b863a31fdd8af ]
+
 rte_flow structures were not being freed when destroyed or flushed.
 
 Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
-Cc: stable at dpdk.org
 
 Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
 Signed-off-by: John Daley <johndale at cisco.com>


More information about the stable mailing list