[dpdk-stable] patch 'cryptodev: fix pool element size for undefined operation' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 22 17:48:56 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/28/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From e8d3f97faebeb8966794354f2b095aae84552c8e Mon Sep 17 00:00:00 2001
From: Junxiao Shi <git at mail1.yoursunny.com>
Date: Tue, 9 Oct 2018 10:16:23 -0400
Subject: [PATCH] cryptodev: fix pool element size for undefined operation

[ upstream commit f49d7e9a99477c00c1f666e999dc62a0f73e5db3 ]

The documentation of rte_crypto_op_pool_create indicates that
specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that
supports all operation types. This change makes the code
consistent with documentation.

Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")

Signed-off-by: Junxiao Shi <git at mail1.yoursunny.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 lib/librte_cryptodev/rte_cryptodev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 63ae23f00..608323fdd 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -1478,4 +1478,7 @@ rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type,
 	} else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) {
 		elt_size += sizeof(struct rte_crypto_asym_op);
+	} else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) {
+		elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op),
+		                    sizeof(struct rte_crypto_asym_op));
 	} else {
 		CDEV_LOG_ERR("Invalid op_type\n");
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-22 16:47:32.383210946 +0000
+++ 0004-cryptodev-fix-pool-element-size-for-undefined-operat.patch	2018-11-22 16:47:32.000000000 +0000
@@ -1,15 +1,16 @@
-From f49d7e9a99477c00c1f666e999dc62a0f73e5db3 Mon Sep 17 00:00:00 2001
+From e8d3f97faebeb8966794354f2b095aae84552c8e Mon Sep 17 00:00:00 2001
 From: Junxiao Shi <git at mail1.yoursunny.com>
 Date: Tue, 9 Oct 2018 10:16:23 -0400
 Subject: [PATCH] cryptodev: fix pool element size for undefined operation
 
+[ upstream commit f49d7e9a99477c00c1f666e999dc62a0f73e5db3 ]
+
 The documentation of rte_crypto_op_pool_create indicates that
 specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that
 supports all operation types. This change makes the code
 consistent with documentation.
 
 Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")
-Cc: stable at dpdk.org
 
 Signed-off-by: Junxiao Shi <git at mail1.yoursunny.com>
 Acked-by: Akhil Goyal <akhil.goyal at nxp.com>


More information about the stable mailing list