[dpdk-stable] patch 'raw/ifpga: check probing error' has been queued to stable release 18.08.1
Kevin Traynor
ktraynor at redhat.com
Thu Nov 22 17:49:47 CET 2018
Hi,
FYI, your patch has been queued to stable release 18.08.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/28/18. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Kevin Traynor
---
>From 2f6edcf4a521dde6c0413f00a89eb3d8cf825c15 Mon Sep 17 00:00:00 2001
From: Rosen Xu <rosen.xu at intel.com>
Date: Tue, 23 Oct 2018 09:50:49 +0800
Subject: [PATCH] raw/ifpga: check probing error
[ upstream commit b6aadd7436bfc1fb2af67aa266588fdd80ca8988 ]
Fixes not checking rte_eal_hotplug_add() return value issue.
Coverity issue: 323508
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Signed-off-by: Rosen Xu <rosen.xu at intel.com>
Acked-by: Shreyansh Jain <shreyansh.jain at nxp.com>
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index 3fed05781..32e318fc3 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -543,4 +543,5 @@ ifpga_cfg_probe(struct rte_vdev_device *dev)
char *name = NULL;
char dev_name[RTE_RAWDEV_NAME_MAX_LEN];
+ int ret = -1;
devargs = dev->device.devargs;
@@ -584,5 +585,5 @@ ifpga_cfg_probe(struct rte_vdev_device *dev)
port, name);
- rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME),
+ ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME),
dev_name, devargs->args);
end:
@@ -592,5 +593,5 @@ end:
free(name);
- return 0;
+ return ret;
}
--
2.19.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2018-11-22 16:47:33.714730084 +0000
+++ 0055-raw-ifpga-check-probing-error.patch 2018-11-22 16:47:32.000000000 +0000
@@ -1,13 +1,14 @@
-From b6aadd7436bfc1fb2af67aa266588fdd80ca8988 Mon Sep 17 00:00:00 2001
+From 2f6edcf4a521dde6c0413f00a89eb3d8cf825c15 Mon Sep 17 00:00:00 2001
From: Rosen Xu <rosen.xu at intel.com>
Date: Tue, 23 Oct 2018 09:50:49 +0800
Subject: [PATCH] raw/ifpga: check probing error
+[ upstream commit b6aadd7436bfc1fb2af67aa266588fdd80ca8988 ]
+
Fixes not checking rte_eal_hotplug_add() return value issue.
Coverity issue: 323508
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
-Cc: stable at dpdk.org
Signed-off-by: Rosen Xu <rosen.xu at intel.com>
Acked-by: Shreyansh Jain <shreyansh.jain at nxp.com>
More information about the stable
mailing list