[dpdk-stable] patch 'test: fix build' has been queued to stable release 18.08.1
Kevin Traynor
ktraynor at redhat.com
Fri Nov 23 11:27:01 CET 2018
Hi,
FYI, your patch has been queued to stable release 18.08.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/29/18. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Kevin Traynor
---
>From 80f97cf77c56ec0a7e89428cf68ba674cb059d7f Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Tue, 6 Nov 2018 14:35:01 +0000
Subject: [PATCH] test: fix build
[ upstream commit fac66b12954d5e00419056a59861ba299fe2c9b6 ]
With "make -C test/" command getting following warnings:
awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
for reading (No such file or directory)
awk: cmd. line:1: fatal: cannot open file
`/test-pipeline/test-pipeline/' for reading (No such file or
directory)
awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
for reading (No such file or directory)
This is because unexpected/invalid MAPFILE param passed to
check-experimental-syms.sh
There is no easy way to unify MAPFILE for different build options,
instead add an input verification to script, and silently ignore wrong
values.
Fixes: a6ec31597a0b ("mk: add experimental tag check")
Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Neil Horman <nhorman at tuxdriver.com>
---
buildtools/check-experimental-syms.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index 5bc8cda17..4ed7ac46d 100755
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -6,4 +6,10 @@ MAPFILE=$1
OBJFILE=$2
+# added check for "make -C test/" usage
+if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
+then
+ exit 0
+fi
+
if [ -d $MAPFILE ]
then
--
2.19.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2018-11-23 10:22:55.729009202 +0000
+++ 0057-test-fix-build.patch 2018-11-23 10:22:54.000000000 +0000
@@ -1,8 +1,10 @@
-From fac66b12954d5e00419056a59861ba299fe2c9b6 Mon Sep 17 00:00:00 2001
+From 80f97cf77c56ec0a7e89428cf68ba674cb059d7f Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Tue, 6 Nov 2018 14:35:01 +0000
Subject: [PATCH] test: fix build
+[ upstream commit fac66b12954d5e00419056a59861ba299fe2c9b6 ]
+
With "make -C test/" command getting following warnings:
awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
for reading (No such file or directory)
@@ -20,7 +22,6 @@
values.
Fixes: a6ec31597a0b ("mk: add experimental tag check")
-Cc: stable at dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Neil Horman <nhorman at tuxdriver.com>
@@ -29,7 +30,7 @@
1 file changed, 6 insertions(+)
diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
-index d0915102d..7d1f3a568 100755
+index 5bc8cda17..4ed7ac46d 100755
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -6,4 +6,10 @@ MAPFILE=$1
More information about the stable
mailing list