[dpdk-stable] patch 'crypto/ccp: fix resource leak' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 29 14:20:32 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/08/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From 94b8e8a7c7c9dda9c22c26e3981cb9dcdb2a08c8 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Sun, 28 Oct 2018 03:19:27 +0000
Subject: [PATCH] crypto/ccp: fix resource leak

[ upstream commit 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 ]

File *fp, opened but not closed, this patch add fclose(fp)

Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Reviewed-by: Ravi Kumar <ravi1.kumar at amd.com>
---
 drivers/crypto/ccp/ccp_pci.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c
index 59152ca5d..1702a09c4 100644
--- a/drivers/crypto/ccp/ccp_pci.c
+++ b/drivers/crypto/ccp/ccp_pci.c
@@ -32,10 +32,13 @@ ccp_check_pci_uio_module(void)
 		while (fgets(buf, sizeof(buf), fp) != NULL) {
 			if (!strncmp(buf, uio_module_names[i],
-				     strlen(uio_module_names[i])))
+				     strlen(uio_module_names[i]))) {
+				fclose(fp);
 				return i;
+			}
 		}
 		i++;
 		rewind(fp);
 	}
+	fclose(fp);
 	printf("Insert igb_uio or uio_pci_generic kernel module(s)");
 	return -1;/* uio not inserted */
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-29 13:11:35.843481696 +0000
+++ 0031-crypto-ccp-fix-resource-leak.patch	2018-11-29 13:11:34.000000000 +0000
@@ -1,12 +1,13 @@
-From 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 Mon Sep 17 00:00:00 2001
+From 94b8e8a7c7c9dda9c22c26e3981cb9dcdb2a08c8 Mon Sep 17 00:00:00 2001
 From: Ferruh Yigit <ferruh.yigit at intel.com>
 Date: Sun, 28 Oct 2018 03:19:27 +0000
 Subject: [PATCH] crypto/ccp: fix resource leak
 
+[ upstream commit 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 ]
+
 File *fp, opened but not closed, this patch add fclose(fp)
 
 Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Reviewed-by: Ravi Kumar <ravi1.kumar at amd.com>


More information about the stable mailing list