[dpdk-stable] patch 'examples/l3fwd-power: fix power library fallback' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 29 14:20:34 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/08/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From 603d16d7ae3b6e162256f28e8d6348b70aa00513 Mon Sep 17 00:00:00 2001
From: Moti Haimovsky <motih at mellanox.com>
Date: Wed, 7 Nov 2018 14:09:28 +0000
Subject: [PATCH] examples/l3fwd-power: fix power library fallback

[ upstream commit 6265115f94d8d40fa1e78e8ea01f6de3a369c61f ]

This patch replaces the rte_exit routine with error printing when
init_power_library() fails and by that restores the previous behavior
of the program (which was to issue an error message and continue
working if init_power_library fails). This allows the user to still
experience the Rx interrupts feature of the DPDK demonstrated in
this program.

Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")

Signed-off-by: Moti Haimovsky <motih at mellanox.com>
Acked-by: David Hunt <david.hunt at intel.com>
---
 examples/l3fwd-power/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d15cd520e..6e6c6b4f0 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1684,5 +1684,5 @@ main(int argc, char **argv)
 
 	if (init_power_library())
-		rte_exit(EXIT_FAILURE, "init_power_library failed\n");
+		RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n");
 
 	if (update_lcore_params() < 0)
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-29 13:11:35.893616992 +0000
+++ 0033-examples-l3fwd-power-fix-power-library-fallback.patch	2018-11-29 13:11:34.000000000 +0000
@@ -1,8 +1,10 @@
-From 6265115f94d8d40fa1e78e8ea01f6de3a369c61f Mon Sep 17 00:00:00 2001
+From 603d16d7ae3b6e162256f28e8d6348b70aa00513 Mon Sep 17 00:00:00 2001
 From: Moti Haimovsky <motih at mellanox.com>
 Date: Wed, 7 Nov 2018 14:09:28 +0000
 Subject: [PATCH] examples/l3fwd-power: fix power library fallback
 
+[ upstream commit 6265115f94d8d40fa1e78e8ea01f6de3a369c61f ]
+
 This patch replaces the rte_exit routine with error printing when
 init_power_library() fails and by that restores the previous behavior
 of the program (which was to issue an error message and continue
@@ -11,7 +13,6 @@
 this program.
 
 Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")
-Cc: stable at dpdk.org
 
 Signed-off-by: Moti Haimovsky <motih at mellanox.com>
 Acked-by: David Hunt <david.hunt at intel.com>
@@ -20,10 +21,10 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
-index 0b3f8fe61..9c7b31564 100644
+index d15cd520e..6e6c6b4f0 100644
 --- a/examples/l3fwd-power/main.c
 +++ b/examples/l3fwd-power/main.c
-@@ -1958,5 +1958,5 @@ main(int argc, char **argv)
+@@ -1684,5 +1684,5 @@ main(int argc, char **argv)
  
  	if (init_power_library())
 -		rte_exit(EXIT_FAILURE, "init_power_library failed\n");


More information about the stable mailing list