[dpdk-stable] patch 'build: set -mfpu=neon flag for armv7-a with meson' has been queued to stable release 18.08.1

Kevin Traynor ktraynor at redhat.com
Thu Nov 29 14:20:39 CET 2018


Hi,

FYI, your patch has been queued to stable release 18.08.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/08/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Kevin Traynor

---
>From d134dc958af966ddce61f8e66a48500c1ea6e8ad Mon Sep 17 00:00:00 2001
From: Luca Boccassi <bluca at debian.org>
Date: Thu, 15 Nov 2018 16:54:18 +0000
Subject: [PATCH] build: set -mfpu=neon flag for armv7-a with meson
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit daf6c3c10e91b1c0dcb872f385116dc4aa477556 ]

Building on armv7a with meson currenctly fails:

/usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
    inlining failed in call to always_inline ‘vld1q_s32’: target
    specific option mismatch

Set -mfpu=neon on that architecture like the legacy makefiles do to fix
the issue.

Fixes: b1d48c41189a ("build: support ARM with meson")

Signed-off-by: Luca Boccassi <bluca at debian.org>
Acked-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
---
 config/arm/meson.build | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 94cca490e..b497901b0 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -90,4 +90,7 @@ if cc.sizeof('void *') != 8
 	dpdk_conf.set('RTE_ARCH_ARM', 1)
 	dpdk_conf.set('RTE_ARCH_ARMv7', 1)
+	# the minimum architecture supported, armv7-a, needs the following,
+	# mk/machine/armv7a/rte.vars.mk sets it too
+	machine_args += '-mfpu=neon'
 else
 	dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-11-29 13:11:36.031376954 +0000
+++ 0038-build-set-mfpu-neon-flag-for-armv7-a-with-meson.patch	2018-11-29 13:11:34.000000000 +0000
@@ -1,4 +1,4 @@
-From daf6c3c10e91b1c0dcb872f385116dc4aa477556 Mon Sep 17 00:00:00 2001
+From d134dc958af966ddce61f8e66a48500c1ea6e8ad Mon Sep 17 00:00:00 2001
 From: Luca Boccassi <bluca at debian.org>
 Date: Thu, 15 Nov 2018 16:54:18 +0000
 Subject: [PATCH] build: set -mfpu=neon flag for armv7-a with meson
@@ -6,6 +6,8 @@
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
+[ upstream commit daf6c3c10e91b1c0dcb872f385116dc4aa477556 ]
+
 Building on armv7a with meson currenctly fails:
 
 /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
@@ -16,7 +18,6 @@
 the issue.
 
 Fixes: b1d48c41189a ("build: support ARM with meson")
-Cc: stable at dpdk.org
 
 Signed-off-by: Luca Boccassi <bluca at debian.org>
 Acked-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
@@ -25,7 +26,7 @@
  1 file changed, 3 insertions(+)
 
 diff --git a/config/arm/meson.build b/config/arm/meson.build
-index 4b23b3954..b75513855 100644
+index 94cca490e..b497901b0 100644
 --- a/config/arm/meson.build
 +++ b/config/arm/meson.build
 @@ -90,4 +90,7 @@ if cc.sizeof('void *') != 8


More information about the stable mailing list