[dpdk-stable] patch 'net/bnxt: reduce polling interval for valid bit' has been queued to LTS release 16.11.9

Luca Boccassi bluca at debian.org
Mon Oct 15 13:51:38 CEST 2018


Hi,

FYI, your patch has been queued to LTS release 16.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/17/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Luca Boccassi

---
>From 0590058e6f7d6bbc6cb3a8de21be174db1014f72 Mon Sep 17 00:00:00 2001
From: Xiaoxin Peng <xiaoxin.peng at broadcom.com>
Date: Fri, 28 Sep 2018 19:00:06 -0700
Subject: [PATCH] net/bnxt: reduce polling interval for valid bit

[ upstream commit a830900063768646a70e5aef1c23ba2530fbc323 ]

Change polling interval for valid bit in bnxt_hwrm_send_message
Poll every 1us instead of 600us.

Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")

Signed-off-by: Xiaoxin Peng <xiaoxin.peng at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index a644fb9c91..dd99c578bd 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -50,7 +50,7 @@
 #include "bnxt_vnic.h"
 #include "hsi_struct_def_dpdk.h"
 
-#define HWRM_CMD_TIMEOUT		2000
+#define HWRM_CMD_TIMEOUT		6000000
 
 /*
  * HWRM Functions (sent to HWRM)
@@ -97,7 +97,7 @@ static int bnxt_hwrm_send_message_locked(struct bnxt *bp, void *msg,
 			if (*valid == HWRM_RESP_VALID_KEY)
 				break;
 		}
-		rte_delay_us(600);
+		rte_delay_us(1);
 	}
 
 	if (i >= HWRM_CMD_TIMEOUT) {
-- 
2.19.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-10-15 12:48:35.062242283 +0100
+++ 0018-net-bnxt-reduce-polling-interval-for-valid-bit.patch	2018-10-15 12:48:34.581096017 +0100
@@ -1,13 +1,14 @@
-From a830900063768646a70e5aef1c23ba2530fbc323 Mon Sep 17 00:00:00 2001
+From 0590058e6f7d6bbc6cb3a8de21be174db1014f72 Mon Sep 17 00:00:00 2001
 From: Xiaoxin Peng <xiaoxin.peng at broadcom.com>
 Date: Fri, 28 Sep 2018 19:00:06 -0700
 Subject: [PATCH] net/bnxt: reduce polling interval for valid bit
 
+[ upstream commit a830900063768646a70e5aef1c23ba2530fbc323 ]
+
 Change polling interval for valid bit in bnxt_hwrm_send_message
 Poll every 1us instead of 600us.
 
 Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")
-Cc: stable at dpdk.org
 
 Signed-off-by: Xiaoxin Peng <xiaoxin.peng at broadcom.com>
 Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
@@ -16,19 +17,19 @@
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
-index 76e443ec18..999976054d 100644
+index a644fb9c91..dd99c578bd 100644
 --- a/drivers/net/bnxt/bnxt_hwrm.c
 +++ b/drivers/net/bnxt/bnxt_hwrm.c
-@@ -26,7 +26,7 @@
- 
- #include <rte_io.h>
+@@ -50,7 +50,7 @@
+ #include "bnxt_vnic.h"
+ #include "hsi_struct_def_dpdk.h"
  
--#define HWRM_CMD_TIMEOUT		10000
+-#define HWRM_CMD_TIMEOUT		2000
 +#define HWRM_CMD_TIMEOUT		6000000
- #define HWRM_SPEC_CODE_1_8_3		0x10803
- #define HWRM_VERSION_1_9_1		0x10901
  
-@@ -135,7 +135,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,
+ /*
+  * HWRM Functions (sent to HWRM)
+@@ -97,7 +97,7 @@ static int bnxt_hwrm_send_message_locked(struct bnxt *bp, void *msg,
  			if (*valid == HWRM_RESP_VALID_KEY)
  				break;
  		}


More information about the stable mailing list