[dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined

Luca Boccassi bluca at debian.org
Sun Sep 16 21:23:16 CEST 2018


On Sun, 2018-09-16 at 14:40 +0000, Honnappa Nagarahalli wrote:
> 
> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net> Sent: Sunday, September 16, 2018 3:16 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>
> Cc: stable at dpdk.org; Yongseok Koh <yskoh at mellanox.com>; nd <nd at arm.co
> m>
> Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags
> when __aarch64__ is defined
> 
> 04/09/2018 20:53, Yongseok Koh:
> > 
> > > On Sep 4, 2018, at 11:41 AM, Yongseok Koh <yskoh at mellanox.com>
> > > wrote:
> > > 
> > > > On Sep 3, 2018, at 1:25 AM, Honnappa Nagarahalli <Honnappa.Naga
> > > > rahalli at arm.com> wrote:
> > > > > I didn't check out the details yet but a quick question.
> > > > > Do you want me to include this patch in 17.11.4?
> > > > > 
> > > > > Yes, please include.
> > > > 
> > > > I didn't realized that this is fixing the meson build.
> > > > 17.11 doesn't have that.
> > > > 
> > > > Thanks,
> > > > Yongseok
> > > > 
> > > > It has a fix for the make build as well. Does it mean, it needs
> > > > to be a different patch?
> > > 
> > > I could've applied the second hunk but actually it was one
> > > minute 
> > > before the release of 17.11.4. I'm sorry that I had to skip this
> > > patch for the release.
> > > 
> > > But, I've applied it (the second hunk only) to the stable/17.11
> > > tree today.
> > > Please check it out and let me know if there's an issue.  This
> > > will 
> > > be included in 17.11.5 (ETA is Nov).
> > > 
> > > FYI, the most favorable way is that you send patches with
> > > '[PATCH 
> > > 17.11]' prefix based on the latest stable/17.11 so that it is
> > > never forgotten.
> > 
> > One more FYI.
> > Even though this was sent to stable (without dev at dpdk.org), as you 
> > have also sent a same patch[1] to dev at dpdk.org, this will be
> > queued 
> > for next stable releases anyway once it is merged to dpdk/master.
> > 
> > [1] https://mails.dpdk.org/archives/dev/2018-September/110713.html
> 
> There is no reason to send this patch specifically to stable at dpdk.org
> .
> The usual process is to wait the patch is applied on master, then
> backport it on stable branches.
> 
> My apologies. I seem to have misunderstood a comment (http://mails.dp
> dk.org/archives/dev/2018-August/110342.html). Do we send patches to
> stable at dpdk.org only when the patches are backported?

In the commit message itself, add:

Cc: stable at dpdk.org

in the text, and it will be considered automatically for backporting
once merged in master.
Only send directly to stable when asked, or when a bug affects only a
stable release but not master (and explain why).

-- 
Kind regards,
Luca Boccassi


More information about the stable mailing list