[dpdk-stable] [PATCH] latency: clear mbuf timestamp after latency calculation

Pattan, Reshma reshma.pattan at intel.com
Thu Sep 20 12:25:21 CEST 2018


Hi,

> -----Original Message-----
> From: longtb5 at viettel.com.vn [mailto:longtb5 at viettel.com.vn]
> Sent: Wednesday, September 19, 2018 9:23 AM
> To: Pattan, Reshma <reshma.pattan at intel.com>
> Cc: dev at dpdk.org; Bao-Long Tran <longtb5 at viettel.com.vn>;
> stable at dpdk.org
> Subject: [PATCH] latency: clear mbuf timestamp after latency calculation
> 
> The timestamp of a mbuf should be cleared after that mbuf was used for
> latency calculation, otherwise future packets which reuse the same mbuf
> would inherit that previous timestamp. The latencystats library looks for
> mbuf with non-zero timestamp, thus incorrectly inherited value would result
> in incorrect latency measurement.
> 
> Cc: stable at dpdk.org
> 
> Signed-off-by: Bao-Long Tran <longtb5 at viettel.com.vn>

You need to add the Fixes line just before CC:  in the commit message. 

Original commit that introduced the bug was  5cd3cac9ed. So fixes should  be  added like below
Fixes: 5cd3cac9ed ("latency: added new library for latency stats").  

You can send v2 with fixes line and my ack. Other than that 

Acked-by: Reshma Pattan <reshma.pattan at intel.com>



More information about the stable mailing list