[dpdk-stable] [PATCH] net/nfp: fix resource leak
Alejandro Lucero
alejandro.lucero at netronome.com
Mon Apr 8 12:49:39 CEST 2019
Coverity issue: 32806
Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
Cc: stable at dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero at netronome.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 33baa989b..0b9db974e 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -690,12 +690,16 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
lockfile = calloc(strlen(home_path) + strlen(lockname) + 1,
sizeof(char));
+ if (!lockfile)
+ return -ENOMEM;
+
strcat(lockfile, home_path);
strcat(lockfile, "/.lock_nfp_secondary");
desc->secondary_lock = open(lockfile, O_RDWR | O_CREAT | O_NONBLOCK,
0666);
if (desc->secondary_lock < 0) {
RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n");
+ free(lockfile);
return desc->secondary_lock;
}
@@ -707,6 +711,7 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
close(desc->secondary_lock);
}
+ free(lockfile);
return rc;
}
--
2.17.1
More information about the stable
mailing list