[dpdk-stable] [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1

Bruce Richardson bruce.richardson at intel.com
Mon Apr 8 22:00:35 CEST 2019


On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.1 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
> 
> Build error:
> .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18:
>   error: initialization of ... from incompatible pointer type ...
>   [-Werror=incompatible-pointer-types]
>     .ndo_fdb_add  = igb_ndo_fdb_add,
>                       ^~~~~~~~~~~~~~~
> 
> ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires
> a new parameter, 'struct netlink_ext_ack *extack':
> Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()")
> 
> ndo_fdb_add() parameter updated with compile time Linux kernel version
> check.
> 
> Cc: stable at dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
Thanks, Ferruh.

This allows my builds to start passing again on bleeding-edge kernels.

Tested-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the stable mailing list