[dpdk-stable] [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

Bruce Richardson bruce.richardson at intel.com
Tue Apr 9 12:40:00 CEST 2019


On Tue, Apr 09, 2019 at 12:34:06PM +0200, David Marchand wrote:
>    On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson
>    <[1]bruce.richardson at intel.com> wrote:
> 
>      On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote:
>      >    On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson
>      >    <[1][2]bruce.richardson at intel.com> wrote:
>      >
>      >      The definition of CPU_AND differs from Linux to BSD, so we
>      need to
>      >      use
>      >      RTE_CPU_AND instead.
>      >      Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample
>      application for
>      >      PQoS CAT and CDP")
>      >      Cc: [2][3]stable at dpdk.org
>      >
>      >    This creates a dependency on backporting c3568ea37670 ("eal:
>      restrict
>      >    control threads to startup CPU affinity") which introduced the
>      >    RTE_CPU_AND macro.
>      >    --
>      >    David Marchand
>      >
>      Shall I drop the stable reference from the v2, then?
> 
>    We can backport in 18.11, as I would expect c3568ea37670 to be
>    backported.
>    The question is more what we want to do with 17.11.
>    We could backport only the macro bits from this patch if needed.
>    --
Yes. I'll leave the stable cc and then each maintainer can decide
themselves on backport. I'll include note in the patch (below cutline) to
call out dependency explicitly.

/Bruce


More information about the stable mailing list