[dpdk-stable] patch 'vhost: fix sprintf with snprintf' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed Apr 10 18:43:29 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/16/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 0eadea12338d0b5db98b87e59507d2a8132673c7 Mon Sep 17 00:00:00 2001
From: Pallantla Poornima <pallantlax.poornima at intel.com>
Date: Mon, 4 Feb 2019 07:28:06 +0000
Subject: [PATCH] vhost: fix sprintf with snprintf

[ upstream commit 7c7b7562252742a6c298de64df486873336fd058 ]

sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.

Fixes: d7280c9fffcb ("vhost: support selective datapath")

Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Acked-by: Tiwei Bie <tiwei.bie at intel.com>
---
 lib/librte_vhost/vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index e7d849ee0..ae721e06b 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -67,5 +67,5 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,
 		return -1;
 
-	sprintf(device_name, "vdpa-dev-%d", i);
+	snprintf(device_name, sizeof(device_name), "vdpa-dev-%d", i);
 	dev = rte_zmalloc(device_name, sizeof(struct rte_vdpa_device),
 			RTE_CACHE_LINE_SIZE);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-10 14:06:09.636535550 +0100
+++ 0021-vhost-fix-sprintf-with-snprintf.patch	2019-04-10 14:06:07.837294862 +0100
@@ -1,13 +1,14 @@
-From 7c7b7562252742a6c298de64df486873336fd058 Mon Sep 17 00:00:00 2001
+From 0eadea12338d0b5db98b87e59507d2a8132673c7 Mon Sep 17 00:00:00 2001
 From: Pallantla Poornima <pallantlax.poornima at intel.com>
 Date: Mon, 4 Feb 2019 07:28:06 +0000
 Subject: [PATCH] vhost: fix sprintf with snprintf
 
+[ upstream commit 7c7b7562252742a6c298de64df486873336fd058 ]
+
 sprintf function is not secure as it doesn't check the length of string.
 More secure function snprintf is used.
 
 Fixes: d7280c9fffcb ("vhost: support selective datapath")
-Cc: stable at dpdk.org
 
 Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
 Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
@@ -17,7 +18,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
-index 1ff9b00b8..321e11f17 100644
+index e7d849ee0..ae721e06b 100644
 --- a/lib/librte_vhost/vdpa.c
 +++ b/lib/librte_vhost/vdpa.c
 @@ -67,5 +67,5 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,


More information about the stable mailing list