[dpdk-stable] patch 'examples/ethtool: fix two typos' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed Apr 10 18:43:50 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/16/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 5e866deb2e415a5bdddef953fd1265fe9066ce22 Mon Sep 17 00:00:00 2001
From: Rami Rosen <ramirose at gmail.com>
Date: Mon, 25 Feb 2019 21:21:37 +0200
Subject: [PATCH] examples/ethtool: fix two typos

[ upstream commit ea43e995799aaa7b15914c3e8237e932a854d6b6 ]

This patch fixes 2 typos in examples/ethtool:

There is no such thing as ethtool_ops::get_driverinfo
It should be get_drvinfo:
see include/linux/ethtool.h in the kernel tree.

rte_net_change_mtu should be ndo_change_mtu:
see include/linux/netdevice.h in the kernel tree.

Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")

Signed-off-by: Rami Rosen <ramirose at gmail.com>
Acked-by: Remy Horton <remy.horton at intel.com>
---
 examples/ethtool/lib/rte_ethtool.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/ethtool/lib/rte_ethtool.h b/examples/ethtool/lib/rte_ethtool.h
index 43adc97a3..31cd5ae4e 100644
--- a/examples/ethtool/lib/rte_ethtool.h
+++ b/examples/ethtool/lib/rte_ethtool.h
@@ -10,5 +10,5 @@
  * Ethtool and Netdevice op API.
  *
- * rte_ethtool_get_driver:          ethtool_ops::get_driverinfo
+ * rte_ethtool_get_driver:          ethtool_ops::get_drvinfo
  * rte_ethtool_get_link:            ethtool_ops::get_link
  * rte_ethtool_get_regs_len:        ethtool_ops::get_regs_len
@@ -24,5 +24,5 @@
  * rte_ethtool_net_set_mac_addr:    net_device_ops::ndo_set_mac_address
  * rte_ethtool_net_validate_addr:   net_device_ops::ndo_validate_addr
- * rte_ethtool_net_change_mtu:      net_device_ops::rte_net_change_mtu
+ * rte_ethtool_net_change_mtu:      net_device_ops::ndo_change_mtu
  * rte_ethtool_net_get_stats64:     net_device_ops::ndo_get_stats64
  * rte_ethtool_net_vlan_rx_add_vid  net_device_ops::ndo_vlan_rx_add_vid
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-10 14:06:11.129084033 +0100
+++ 0042-examples-ethtool-fix-two-typos.patch	2019-04-10 14:06:07.978291633 +0100
@@ -1,8 +1,10 @@
-From ea43e995799aaa7b15914c3e8237e932a854d6b6 Mon Sep 17 00:00:00 2001
+From 5e866deb2e415a5bdddef953fd1265fe9066ce22 Mon Sep 17 00:00:00 2001
 From: Rami Rosen <ramirose at gmail.com>
 Date: Mon, 25 Feb 2019 21:21:37 +0200
 Subject: [PATCH] examples/ethtool: fix two typos
 
+[ upstream commit ea43e995799aaa7b15914c3e8237e932a854d6b6 ]
+
 This patch fixes 2 typos in examples/ethtool:
 
 There is no such thing as ethtool_ops::get_driverinfo
@@ -13,7 +15,6 @@
 see include/linux/netdevice.h in the kernel tree.
 
 Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
-Cc: stable at dpdk.org
 
 Signed-off-by: Rami Rosen <ramirose at gmail.com>
 Acked-by: Remy Horton <remy.horton at intel.com>


More information about the stable mailing list