[dpdk-stable] patch 'test/spinlock: remove delay for correct benchmarking' has been queued to LTS release 18.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/24/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 6e8cc16a52e3b261ad099f5eb89f706dfb284c22 Mon Sep 17 00:00:00 2001
From: Gavin Hu <gavin.hu at arm.com>
Date: Fri, 8 Mar 2019 15:56:35 +0800
Subject: [PATCH] test/spinlock: remove delay for correct benchmarking

[ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ]

The test is to benchmark the performance of spinlock by counting the
number of spinlock acquire and release operations within the specified
time.
A typical pair of lock and unlock operations costs tens or hundreds of
nano seconds, in comparison to this, delaying 1 us outside of the locked
region is too much, compromising the goal of benchmarking the lock and
unlock performance.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Gavin Hu <gavin.hu at arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
Reviewed-by: Joyce Kong <joyce.kong at arm.com>
Reviewed-by: Phil Yang <phil.yang at arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Reviewed-by: Ola Liljedahl <ola.liljedahl at arm.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
Acked-by: Nipun Gupta <nipun.gupta at nxp.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
 test/test/test_spinlock.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c
index 73bff128e..6795195ae 100644
--- a/test/test/test_spinlock.c
+++ b/test/test/test_spinlock.c
@@ -121,6 +121,4 @@ load_loop_fn(void *func_param)
 		if (use_lock)
 			rte_spinlock_unlock(&lk);
-		/* delay to make lock duty cycle slighlty realistic */
-		rte_delay_us(1);
 		time_diff = rte_get_timer_cycles() - begin;
 	}
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-16 15:34:27.695249272 +0100
+++ 0056-test-spinlock-remove-delay-for-correct-benchmarking.patch	2019-04-16 15:34:25.235178729 +0100
@@ -1,8 +1,10 @@
-From 9119ad305db027b5c87e27b13fde9d60f9aa9a1f Mon Sep 17 00:00:00 2001
+From 6e8cc16a52e3b261ad099f5eb89f706dfb284c22 Mon Sep 17 00:00:00 2001
 From: Gavin Hu <gavin.hu at arm.com>
 Date: Fri, 8 Mar 2019 15:56:35 +0800
 Subject: [PATCH] test/spinlock: remove delay for correct benchmarking
 
+[ upstream commit 9119ad305db027b5c87e27b13fde9d60f9aa9a1f ]
+
 The test is to benchmark the performance of spinlock by counting the
 number of spinlock acquire and release operations within the specified
 time.
@@ -12,7 +14,6 @@
 unlock performance.
 
 Fixes: af75078fece3 ("first public release")
-Cc: stable at dpdk.org
 
 Signed-off-by: Gavin Hu <gavin.hu at arm.com>
 Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
@@ -24,13 +25,13 @@
 Acked-by: Nipun Gupta <nipun.gupta at nxp.com>
 Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
 ---
- app/test/test_spinlock.c | 2 --
+ test/test/test_spinlock.c | 2 --
  1 file changed, 2 deletions(-)
 
-diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c
+diff --git a/test/test/test_spinlock.c b/test/test/test_spinlock.c
 index 73bff128e..6795195ae 100644
---- a/app/test/test_spinlock.c
-+++ b/app/test/test_spinlock.c
+--- a/test/test/test_spinlock.c
++++ b/test/test/test_spinlock.c
 @@ -121,6 +121,4 @@ load_loop_fn(void *func_param)
  		if (use_lock)
  			rte_spinlock_unlock(&lk);