[dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value
Andrius Sirvys
andrius.sirvys at intel.com
Thu Apr 18 10:52:06 CEST 2019
Checking the return value of rte_metrics_update_values, if failed
returning that value.
Coverity had picked up that that the return value wasn't being checked.
Coverity issue: 336863
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Cc: remy.horton at intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
Acked-by: Rami Rosen <ramirose at gmail.com>
---
v2: Fixed checkpatch warnings and build failures
---
lib/librte_bitratestats/rte_bitrate.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/librte_bitratestats/rte_bitrate.c b/lib/librte_bitratestats/rte_bitrate.c
index c4b28f624..639e47547 100644
--- a/lib/librte_bitratestats/rte_bitrate.c
+++ b/lib/librte_bitratestats/rte_bitrate.c
@@ -67,6 +67,7 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
int64_t delta;
const int64_t alpha_percent = 20;
uint64_t values[6];
+ int ret;
if (bitrate_data == NULL)
return -EINVAL;
@@ -124,7 +125,10 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
values[3] = port_data->mean_obits;
values[4] = port_data->peak_ibits;
values[5] = port_data->peak_obits;
- rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
+ ret = rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
values, ARRAY_SIZE(values));
+ if (ret < 0)
+ return ret;
+
return 0;
}
--
2.17.1
More information about the stable
mailing list