[dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

Pei, Andy andy.pei at intel.com
Tue Apr 23 03:19:26 CEST 2019


Hi Thomas,

My patch is the same as LI Qiang's patch.
I was told that Qiang's patch cannot get onto the patchwork, so I just help him do this.

-----Original Message-----
From: Thomas Monjalon [mailto:thomas at monjalon.net] 
Sent: Tuesday, April 23, 2019 1:52 AM
To: Xu, Rosen <rosen.xu at intel.com>; Pei, Andy <andy.pei at intel.com>
Cc: stable at dpdk.org; dev at dpdk.org; Kovacevic, Marko <marko.kovacevic at intel.com>; liq3ea at 163.com
Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

> > In rte_fpga_do_pr() function, if 'stat' returns error,
> > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that 
> > has been opened.
> > After this patch, 'file_fd' is closed before rte_fpga_do_pr() 
> > returns -EINVAL when 'stat' returns error
> > 
> > Coverity issue: 279441
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Cc: rosen.xu at intel.com
> > Cc: marko.kovacevic at intel.com
> > Cc: liq3ea at 163.com
> > Cc: andy.pei at intel.com
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Andy Pei <andy.pei at intel.com>
> 
> Acked-by: Rosen Xu <rosen.xu at intel.com>

Li Qiang <liq3ea at 163.com> proposed the same patch.
Why he is not referenced here?
Which patch should I merge?





More information about the stable mailing list