[dpdk-stable] [PATCH] net/ring: fix return value check

[Bruce Richardson]

On Tue, Apr 23, 2019 at 04:31:00PM +0100, Ferruh Yigit wrote:
> 'rte_eth_dev_get_port_by_name()' return value is not checked caught by
> coverity, adding return value check.
> 
> Coverity issue: 305853
> Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
>  drivers/net/ring/rte_eth_ring.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
> index 115a882b5..5ec646594 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -385,7 +385,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
>  		return -1;
>  	}
>  
> -	rte_eth_dev_get_port_by_name(ring_name, &port_id);
> +	ret = rte_eth_dev_get_port_by_name(ring_name, &port_id);
> +	if (ret) {
> +		rte_errno = ENODEV;
> +		return -1;
> +	}
>  
>  	return port_id;
>  }

Looks reasonable to me.

Acked-by: Bruce Richardson <bruce.richardson at intel.com>