[dpdk-stable] patch 'eal/linux: remove thread ID from debug message' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Thu Apr 25 17:39:46 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/01/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on the 18.11 branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From 339f737749f8962a06d65b77dcd07128165635aa Mon Sep 17 00:00:00 2001
From: Natanael Copa <ncopa at alpinelinux.org>
Date: Wed, 13 Mar 2019 18:06:57 +0100
Subject: [PATCH] eal/linux: remove thread ID from debug message

[ upstream commit c2d82896ac6d9ea02c76044a8d4a612023ccf571 ]

There is no guarantee that pthread_self() returns the thread ID or that
pthread_t is an integer. The thread ID is not that useful so simply
remove it.

This fixes the following warning when building with musl libc:

lib/librte_eal/linuxapp/eal/eal_dev.c: In function 'sigbus_handler':
lib/librte_eal/linuxapp/eal/eal_dev.c:70:3: warning:
cast from pointer to integer of different size [-Wpointer-to-int-cast]
   (int)pthread_self(), info->si_addr);
   ^

Fixes: 0fc54536b14a ("eal: add failure handling for hot-unplug")

Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>
---
 lib/librte_eal/linuxapp/eal/eal_dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c b/lib/librte_eal/linuxapp/eal/eal_dev.c
index 2830c8687..c41809380 100644
--- a/lib/librte_eal/linuxapp/eal/eal_dev.c
+++ b/lib/librte_eal/linuxapp/eal/eal_dev.c
@@ -67,6 +67,6 @@ static void sigbus_handler(int signum, siginfo_t *info,
 	int ret;
 
-	RTE_LOG(DEBUG, EAL, "Thread[%d] catch SIGBUS, fault address:%p\n",
-		(int)pthread_self(), info->si_addr);
+	RTE_LOG(DEBUG, EAL, "Thread catch SIGBUS, fault address:%p\n",
+		info->si_addr);
 
 	rte_spinlock_lock(&failure_handle_lock);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-25 16:37:47.252158662 +0100
+++ 0011-eal-linux-remove-thread-ID-from-debug-message.patch	2019-04-25 16:37:46.695296093 +0100
@@ -1 +1 @@
-From c2d82896ac6d9ea02c76044a8d4a612023ccf571 Mon Sep 17 00:00:00 2001
+From 339f737749f8962a06d65b77dcd07128165635aa Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c2d82896ac6d9ea02c76044a8d4a612023ccf571 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
- lib/librte_eal/linux/eal/eal_dev.c | 4 ++--
+ lib/librte_eal/linuxapp/eal/eal_dev.c | 4 ++--
@@ -26 +27 @@
-diff --git a/lib/librte_eal/linux/eal/eal_dev.c b/lib/librte_eal/linux/eal/eal_dev.c
+diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c b/lib/librte_eal/linuxapp/eal/eal_dev.c
@@ -28,2 +29,2 @@
---- a/lib/librte_eal/linux/eal/eal_dev.c
-+++ b/lib/librte_eal/linux/eal/eal_dev.c
+--- a/lib/librte_eal/linuxapp/eal/eal_dev.c
++++ b/lib/librte_eal/linuxapp/eal/eal_dev.c


More information about the stable mailing list