[dpdk-stable] patch 'app/testpmd: remove useless casts on statistics' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Thu Apr 25 17:39:56 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/01/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on the 18.11 branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From 300a6ca3eb0ca922099b4d22d5f62053cfb71cb3 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Mon, 25 Mar 2019 09:51:45 +0100
Subject: [PATCH] app/testpmd: remove useless casts on statistics

[ upstream commit 7718296d06916d0b2029763913944f0067a2d0dd ]

Caught by code review while investigating the fwd stats display code.

Fixes: af75078fece3 ("first public release")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/testpmd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d62c1594d..55a4ee407 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1389,5 +1389,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
 		       "%-"PRIu64"\n",
 		       stats->ipackets, stats->imissed,
-		       (uint64_t) (stats->ipackets + stats->imissed));
+		       stats->ipackets + stats->imissed);
 
 		if (cur_fwd_eng == &csum_fwd_engine)
@@ -1403,5 +1403,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
 		       "%-"PRIu64"\n",
 		       stats->opackets, port->tx_dropped,
-		       (uint64_t) (stats->opackets + port->tx_dropped));
+		       stats->opackets + port->tx_dropped);
 	}
 	else {
@@ -1409,5 +1409,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
 		       "%14"PRIu64"\n",
 		       stats->ipackets, stats->imissed,
-		       (uint64_t) (stats->ipackets + stats->imissed));
+		       stats->ipackets + stats->imissed);
 
 		if (cur_fwd_eng == &csum_fwd_engine)
@@ -1424,5 +1424,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
 		       "%14"PRIu64"\n",
 		       stats->opackets, port->tx_dropped,
-		       (uint64_t) (stats->opackets + port->tx_dropped));
+		       stats->opackets + port->tx_dropped);
 	}
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-25 16:37:47.666183207 +0100
+++ 0021-app-testpmd-remove-useless-casts-on-statistics.patch	2019-04-25 16:37:46.713295681 +0100
@@ -1 +1 @@
-From 7718296d06916d0b2029763913944f0067a2d0dd Mon Sep 17 00:00:00 2001
+From 300a6ca3eb0ca922099b4d22d5f62053cfb71cb3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7718296d06916d0b2029763913944f0067a2d0dd ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 05a3dce49..c78d52457 100644
+index d62c1594d..55a4ee407 100644
@@ -23 +24 @@
-@@ -1377,5 +1377,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
+@@ -1389,5 +1389,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
@@ -30 +31 @@
-@@ -1391,5 +1391,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
+@@ -1403,5 +1403,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
@@ -37 +38 @@
-@@ -1397,5 +1397,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
+@@ -1409,5 +1409,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
@@ -44 +45 @@
-@@ -1412,5 +1412,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)
+@@ -1424,5 +1424,5 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)


More information about the stable mailing list