[dpdk-stable] patch 'test/distributor: replace sprintf with strlcpy' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Thu Apr 25 17:40:26 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/01/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on the 18.11 branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From 3a88e8f3fbcd7ea4347dce8dabf677e99cc596fc Mon Sep 17 00:00:00 2001
From: Pallantla Poornima <pallantlax.poornima at intel.com>
Date: Thu, 14 Feb 2019 09:45:49 +0000
Subject: [PATCH] test/distributor: replace sprintf with strlcpy

[ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ]

sprintf function is not secure as it doesn't check the length of string.
replaced sprintf with strlcpy.

Fixes: f74df2c57e ("test/distributor: test single and burst API")

Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
Acked-by: David Hunt <david.hunt at intel.com>
---
 test/test/test_distributor.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c
index 98919ec0c..da3348fd1 100644
--- a/test/test/test_distributor.c
+++ b/test/test/test_distributor.c
@@ -12,4 +12,5 @@
 #include <rte_mbuf.h>
 #include <rte_distributor.h>
+#include <rte_string_fns.h>
 
 #define ITER_POWER 20 /* log 2 of how many iterations we do when timing. */
@@ -643,7 +644,9 @@ test_distributor(void)
 		worker_params.dist = dist[i];
 		if (i)
-			sprintf(worker_params.name, "burst");
+			strlcpy(worker_params.name, "burst",
+					sizeof(worker_params.name));
 		else
-			sprintf(worker_params.name, "single");
+			strlcpy(worker_params.name, "single",
+					sizeof(worker_params.name));
 
 		rte_eal_mp_remote_launch(handle_work,
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-25 16:37:48.949462737 +0100
+++ 0051-test-distributor-replace-sprintf-with-strlcpy.patch	2019-04-25 16:37:46.768294423 +0100
@@ -1 +1 @@
-From 7ab0770233ed5bb89845abf6b978ef15b2520bd8 Mon Sep 17 00:00:00 2001
+From 3a88e8f3fbcd7ea4347dce8dabf677e99cc596fc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7ab0770233ed5bb89845abf6b978ef15b2520bd8 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- app/test/test_distributor.c | 7 +++++--
+ test/test/test_distributor.c | 7 +++++--
@@ -18 +19 @@
-diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
+diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c
@@ -20,2 +21,2 @@
---- a/app/test/test_distributor.c
-+++ b/app/test/test_distributor.c
+--- a/test/test/test_distributor.c
++++ b/test/test/test_distributor.c


More information about the stable mailing list