[dpdk-stable] patch 'net/nfp: fix potential integer overflow' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Tue Apr 30 19:01:07 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on a temporary branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From 0f39eac8640f9eb952e3e4f5986d39de7712ee64 Mon Sep 17 00:00:00 2001
From: Alejandro Lucero <alejandro.lucero at netronome.com>
Date: Mon, 8 Apr 2019 10:39:56 +0100
Subject: [PATCH] net/nfp: fix potential integer overflow

[ upstream commit 3243f7c0d8e445fe7607a2dcac24bffffa830cae ]

Coverity issue: 277204
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")

Signed-off-by: Alejandro Lucero <alejandro.lucero at netronome.com>
---
 drivers/net/nfp/nfp_net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 49d4e2bd5..7d99f080a 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2793,7 +2793,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
 	case PCI_DEVICE_ID_NFP6000_VF_NIC:
 		start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_TXQ);
-		tx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+		tx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
 		start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_RXQ);
-		rx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+		rx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
 		break;
 	default:
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-30 17:58:14.389413446 +0100
+++ 0012-net-nfp-fix-potential-integer-overflow.patch	2019-04-30 17:58:13.772140496 +0100
@@ -1 +1 @@
-From 3243f7c0d8e445fe7607a2dcac24bffffa830cae Mon Sep 17 00:00:00 2001
+From 0f39eac8640f9eb952e3e4f5986d39de7712ee64 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3243f7c0d8e445fe7607a2dcac24bffffa830cae ]
+
@@ -8 +9,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
-index 50058e056..d4c94d7cc 100644
+index 49d4e2bd5..7d99f080a 100644
@@ -19 +20 @@
-@@ -2856,7 +2856,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
+@@ -2793,7 +2793,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)


More information about the stable mailing list