[dpdk-stable] patch 'app/testpmd: fix return value check' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Tue Apr 30 19:01:12 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on a temporary branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From b40c5764bd58bca3738300635f009f8889d87dc1 Mon Sep 17 00:00:00 2001
From: Chenbo Xia <chenbo.xia at intel.com>
Date: Wed, 10 Apr 2019 02:46:36 +0000
Subject: [PATCH] app/testpmd: fix return value check

[ upstream commit 2b0e0eba2c37a1d53bf179c2e676eb920a6ac85c ]

Fix unchecked return value issue for rte_eth_dev_configure.

Coverity issue: 195021
Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Rami Rosen <ramirose at gmail.com>
---
 app/test-pmd/testpmd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 27b3c1183..cf983b16b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2963,6 +2963,7 @@ init_port_dcb_config(portid_t pid,
 
 	/* re-configure the device . */
-	rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
-
+	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
+	if (retval < 0)
+		return retval;
 	rte_eth_dev_info_get(pid, &rte_port->dev_info);
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-30 17:58:14.623664380 +0100
+++ 0017-app-testpmd-fix-return-value-check.patch	2019-04-30 17:58:13.788140168 +0100
@@ -1 +1 @@
-From 2b0e0eba2c37a1d53bf179c2e676eb920a6ac85c Mon Sep 17 00:00:00 2001
+From b40c5764bd58bca3738300635f009f8889d87dc1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2b0e0eba2c37a1d53bf179c2e676eb920a6ac85c ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 2e99d99e1..d01165f3c 100644
+index 27b3c1183..cf983b16b 100644
@@ -22 +23 @@
-@@ -3038,6 +3038,7 @@ init_port_dcb_config(portid_t pid,
+@@ -2963,6 +2963,7 @@ init_port_dcb_config(portid_t pid,


More information about the stable mailing list