[dpdk-stable] patch 'examples/fips_validation: fix CMAC test' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Tue Apr 30 19:01:23 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on a temporary branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From 894eae3b831e752cfe4c2c2343f453a7291e10fa Mon Sep 17 00:00:00 2001
From: Marko Kovacevic <marko.kovacevic at intel.com>
Date: Mon, 15 Apr 2019 16:04:48 +0100
Subject: [PATCH] examples/fips_validation: fix CMAC test

[ upstream commit 083a277754f664d6f5d3af166f1f45ae0cb32cc3 ]

As a result of the cmac test running the test where
PT len is 65536 it should give a result back to the
user USER1: Error -1: Prepare op USER1: PT len 65536
as this MSG len is not supported. Issue was
that the application was not freeing the op properly after
a while causing the app to fail.

CRYPTODEV: rte_cryptodev_sym_session_create() line 1340:
couldn't get object from session mempool
USER1: Error -12: test block
USER1: Error -12: Failed test CMAC/req/CMAC.req

Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing")

Signed-off-by: Marko Kovacevic <marko.kovacevic at intel.com>
---
 examples/fips_validation/main.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index e7559c633..40785decb 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -807,5 +807,5 @@ fips_run_test(void)
 		RTE_LOG(ERR, USER1, "Error %i: Init session\n",
 				ret);
-		return ret;
+		goto exit;
 	}
 
@@ -814,10 +814,11 @@ fips_run_test(void)
 		RTE_LOG(ERR, USER1, "Error %i: Prepare op\n",
 				ret);
-		return ret;
+		goto exit;
 	}
 
 	if (rte_cryptodev_enqueue_burst(env.dev_id, 0, &env.op, 1) < 1) {
 		RTE_LOG(ERR, USER1, "Error: Failed enqueue\n");
-		return ret;
+		ret = -1;
+		goto exit;
 	}
 
@@ -831,4 +832,5 @@ fips_run_test(void)
 	vec.status = env.op->status;
 
+exit:
 	rte_cryptodev_sym_session_clear(env.dev_id, env.sess);
 	rte_cryptodev_sym_session_free(env.sess);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-30 17:58:15.142556804 +0100
+++ 0028-examples-fips_validation-fix-CMAC-test.patch	2019-04-30 17:58:13.803139861 +0100
@@ -1 +1 @@
-From 083a277754f664d6f5d3af166f1f45ae0cb32cc3 Mon Sep 17 00:00:00 2001
+From 894eae3b831e752cfe4c2c2343f453a7291e10fa Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 083a277754f664d6f5d3af166f1f45ae0cb32cc3 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index 5e3d5baa8..aef45055e 100644
+index e7559c633..40785decb 100644
@@ -30 +31 @@
-@@ -950,5 +950,5 @@ fips_run_test(void)
+@@ -807,5 +807,5 @@ fips_run_test(void)
@@ -37 +38 @@
-@@ -957,10 +957,11 @@ fips_run_test(void)
+@@ -814,10 +814,11 @@ fips_run_test(void)
@@ -51 +52 @@
-@@ -974,4 +975,5 @@ fips_run_test(void)
+@@ -831,4 +832,5 @@ fips_run_test(void)


More information about the stable mailing list