[dpdk-stable] patch 'ethdev: avoid error on PCI unplug of closed port' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Tue Aug 27 11:29:42 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/03/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/48ece96d63f88c0aa28b85bed4ecac744b894c8d

Thanks.

Kevin Traynor

---
>From 48ece96d63f88c0aa28b85bed4ecac744b894c8d Mon Sep 17 00:00:00 2001
From: Andrew Rybchenko <arybchenko at solarflare.com>
Date: Fri, 21 Jun 2019 10:40:39 +0100
Subject: [PATCH] ethdev: avoid error on PCI unplug of closed port

[ upstream commit ca5ba1b6972f381d410f9e53b650ba179e776225 ]

If PCI Ethernet device driver removes it on close
(RTE_ETH_DEV_CLOSE_REMOVE) and later PCI device itself is unplugged,
it should not fail because of Ethernet device is already removed.

Fixes: 23ea57a2a0ce ("ethdev: complete closing of port")

Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
Reviewed-by: Ivan Malov <ivan.malov at oktetlabs.ru>
Reported-by: David Marchand <david.marchand at redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 lib/librte_ethdev/rte_ethdev_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h
index 23257e986..ccdbb46ec 100644
--- a/lib/librte_ethdev/rte_ethdev_pci.h
+++ b/lib/librte_ethdev/rte_ethdev_pci.h
@@ -185,5 +185,5 @@ rte_eth_dev_pci_generic_remove(struct rte_pci_device *pci_dev,
 	eth_dev = rte_eth_dev_allocated(pci_dev->device.name);
 	if (!eth_dev)
-		return -ENODEV;
+		return 0;
 
 	if (dev_uninit) {
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-27 09:40:11.196263124 +0100
+++ 0005-ethdev-avoid-error-on-PCI-unplug-of-closed-port.patch	2019-08-27 09:40:10.846146185 +0100
@@ -1 +1 @@
-From ca5ba1b6972f381d410f9e53b650ba179e776225 Mon Sep 17 00:00:00 2001
+From 48ece96d63f88c0aa28b85bed4ecac744b894c8d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ca5ba1b6972f381d410f9e53b650ba179e776225 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list