[dpdk-stable] patch 'compress/isal: fix use after free' has been queued to LTS release 18.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/03/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/e05f689f71cc1df8b4cfef55fe8d07220315c17d

Thanks.

Kevin Traynor

---
>From e05f689f71cc1df8b4cfef55fe8d07220315c17d Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 21 May 2019 07:47:13 -0700
Subject: [PATCH] compress/isal: fix use after free

[ upstream commit abdb798ae22ee4374e9152580f22ff5fb42193a0 ]

The release function was using qp->stream after already
releasing it and the null pointer checking was missing.

Also since rte_free(NULL) is a no-op, remove unnecessary
checks for NULL.

Coverity issure: 340860
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Lee Daly <lee.daly at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>
---
 drivers/compress/isal/isal_compress_pmd_ops.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 472e54e8e..a395a660d 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -170,16 +170,10 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
 		return -EINVAL;
 
-	if (qp->stream != NULL)
-		rte_free(qp->stream);
-
-	if (qp->stream->level_buf != NULL)
+	if (qp->stream)
 		rte_free(qp->stream->level_buf);
 
-	if (qp->state != NULL)
-		rte_free(qp->state);
-
-	if (qp->processed_pkts != NULL)
-		rte_ring_free(qp->processed_pkts);
-
+	rte_free(qp->state);
+	rte_ring_free(qp->processed_pkts);
+	rte_free(qp->stream);
 	rte_free(qp);
 	dev->data->queue_pairs[qp_id] = NULL;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-27 09:40:11.797327121 +0100
+++ 0016-compress-isal-fix-use-after-free.patch	2019-08-27 09:40:10.891145092 +0100
@@ -1 +1 @@
-From abdb798ae22ee4374e9152580f22ff5fb42193a0 Mon Sep 17 00:00:00 2001
+From e05f689f71cc1df8b4cfef55fe8d07220315c17d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit abdb798ae22ee4374e9152580f22ff5fb42193a0 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index fe9995992..77ac6fcf2 100644
+index 472e54e8e..a395a660d 100644
@@ -27 +28 @@
-@@ -172,16 +172,10 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
+@@ -170,16 +170,10 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)