[dpdk-stable] patch 'app/crypto-perf: check lcore job failure' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Tue Aug 27 11:30:05 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/03/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/08e8a0ed44ee22f3fa39d55a3982ceca886f6058

Thanks.

Kevin Traynor

---
>From 08e8a0ed44ee22f3fa39d55a3982ceca886f6058 Mon Sep 17 00:00:00 2001
From: Tomasz Jozwiak <tjozwiakgm at gmail.com>
Date: Fri, 14 Jun 2019 22:56:45 +0200
Subject: [PATCH] app/crypto-perf: check lcore job failure

[ upstream commit 5908e7e837a62fe62c48094d8c2e947242f8fac3 ]

Currently, there's no return status check from lcore's jobs.
In case of fail - crypto-perf tool returns success anyway.
This patch adds such a detection and returns proper status at the end.

Fixes: ce8af1a4398d ("app/crypto-perf: wait for cores launched by app")

Signed-off-by: Tomasz Jozwiak <tjozwiakgm at gmail.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 app/test-crypto-perf/main.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 0aa0de8bd..921394799 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -628,7 +628,10 @@ main(int argc, char **argv)
 			if (i == total_nb_qps)
 				break;
-			rte_eal_wait_lcore(lcore_id);
+			ret |= rte_eal_wait_lcore(lcore_id);
 			i++;
 		}
+
+		if (ret != EXIT_SUCCESS)
+			goto err;
 	} else {
 
@@ -655,8 +658,11 @@ main(int argc, char **argv)
 				if (i == total_nb_qps)
 					break;
-				rte_eal_wait_lcore(lcore_id);
+				ret |= rte_eal_wait_lcore(lcore_id);
 				i++;
 			}
 
+			if (ret != EXIT_SUCCESS)
+				goto err;
+
 			/* Get next size from range or list */
 			if (opts.inc_buffer_size != 0)
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-27 09:40:12.436112978 +0100
+++ 0028-app-crypto-perf-check-lcore-job-failure.patch	2019-08-27 09:40:10.911144607 +0100
@@ -1 +1 @@
-From 5908e7e837a62fe62c48094d8c2e947242f8fac3 Mon Sep 17 00:00:00 2001
+From 08e8a0ed44ee22f3fa39d55a3982ceca886f6058 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5908e7e837a62fe62c48094d8c2e947242f8fac3 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index db0290751..ce92a9687 100644
+index 0aa0de8bd..921394799 100644
@@ -23 +24 @@
-@@ -666,7 +666,10 @@ main(int argc, char **argv)
+@@ -628,7 +628,10 @@ main(int argc, char **argv)
@@ -35 +36 @@
-@@ -693,8 +696,11 @@ main(int argc, char **argv)
+@@ -655,8 +658,11 @@ main(int argc, char **argv)


More information about the stable mailing list