[dpdk-stable] patch 'net/bnxt: fix crash on probe failure' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Wed Aug 28 15:41:59 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/5c1b72f67e354bcde6f3dad0f791a9150ce4ac61

Thanks.

Kevin Traynor

---
>From 5c1b72f67e354bcde6f3dad0f791a9150ce4ac61 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Wed, 17 Jul 2019 16:11:26 +0530
Subject: [PATCH] net/bnxt: fix crash on probe failure

[ upstream commit 2c43b439e50df5e1ebf8f97c1e600825d9601ec9 ]

Fixed couple of possible segfaults due to NULL pointer
dereference in case of probe failure.

Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_irq.c  | 3 +++
 drivers/net/bnxt/bnxt_vnic.c | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
index e3aac7cbe..8ea17793e 100644
--- a/drivers/net/bnxt/bnxt_irq.c
+++ b/drivers/net/bnxt/bnxt_irq.c
@@ -53,4 +53,7 @@ void bnxt_free_int(struct bnxt *bp)
 	struct bnxt_irq *irq;
 
+	if (bp->irq_tbl == NULL)
+		return;
+
 	irq = bp->irq_tbl;
 	if (irq) {
diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c
index aebfb1f1c..9ebe7c963 100644
--- a/drivers/net/bnxt/bnxt_vnic.c
+++ b/drivers/net/bnxt/bnxt_vnic.c
@@ -90,4 +90,7 @@ void bnxt_free_vnic_attributes(struct bnxt *bp)
 	unsigned int i;
 
+	if (bp->vnic_info == NULL)
+		return;
+
 	for (i = 0; i < bp->max_vnics; i++) {
 		vnic = &bp->vnic_info[i];
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:33.151776005 +0100
+++ 0024-net-bnxt-fix-crash-on-probe-failure.patch	2019-08-28 14:32:31.636957471 +0100
@@ -1 +1 @@
-From 2c43b439e50df5e1ebf8f97c1e600825d9601ec9 Mon Sep 17 00:00:00 2001
+From 5c1b72f67e354bcde6f3dad0f791a9150ce4ac61 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2c43b439e50df5e1ebf8f97c1e600825d9601ec9 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 0bb3eb4fa..61f7498a5 100644
+index e3aac7cbe..8ea17793e 100644
@@ -32 +33 @@
-index 262cfc18d..20e5bf2d1 100644
+index aebfb1f1c..9ebe7c963 100644


More information about the stable mailing list