[dpdk-stable] patch 'net/bnxt: check invalid VNIC in cleanup path' has been queued to LTS release 18.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/0d1f2372d15838f922aa344d885e30e55bf92f78

Thanks.

Kevin Traynor

---
>From 0d1f2372d15838f922aa344d885e30e55bf92f78 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Wed, 17 Jul 2019 16:11:36 +0530
Subject: [PATCH] net/bnxt: check invalid VNIC in cleanup path

[ upstream commit fcaf844e993b5850021a7e54e27d21904b805329 ]

The cleanup/rollback operation post rte_eth_dev_start failure might end
up invoking an HWRM cmd even on an invalid vNIC resulting in error
messages being logged needlessly.
Fix to check for the same before issuing the HWRM cmd.

Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 6eff260ca..53c31baf4 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2119,4 +2119,9 @@ void bnxt_free_all_hwrm_resources(struct bnxt *bp)
 		struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
 
+		if (vnic->fw_vnic_id == INVALID_HW_RING_ID) {
+			PMD_DRV_LOG(DEBUG, "Invalid vNIC ID\n");
+			return;
+		}
+
 		bnxt_clear_hwrm_vnic_flows(bp, vnic);
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:33.453668545 +0100
+++ 0029-net-bnxt-check-invalid-VNIC-in-cleanup-path.patch	2019-08-28 14:32:31.650957160 +0100
@@ -1 +1 @@
-From fcaf844e993b5850021a7e54e27d21904b805329 Mon Sep 17 00:00:00 2001
+From 0d1f2372d15838f922aa344d885e30e55bf92f78 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit fcaf844e993b5850021a7e54e27d21904b805329 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 84cda5e6c..1a0265f8a 100644
+index 6eff260ca..53c31baf4 100644
@@ -25 +26 @@
-@@ -2326,4 +2326,9 @@ void bnxt_free_all_hwrm_resources(struct bnxt *bp)
+@@ -2119,4 +2119,9 @@ void bnxt_free_all_hwrm_resources(struct bnxt *bp)