[dpdk-stable] patch 'net/bnxt: fix unconditional wait in link update' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Wed Aug 28 15:42:15 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/052a49557654602d4a3567c81cb761813a6cf4c7

Thanks.

Kevin Traynor

---
>From 052a49557654602d4a3567c81cb761813a6cf4c7 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Thu, 18 Jul 2019 09:05:58 +0530
Subject: [PATCH] net/bnxt: fix unconditional wait in link update

[ upstream commit 0a44537589454a9aba3e9ad392218ad433fbf529 ]

There is an unconditional delay in link update op.
Fixed it to wait only if wait for request completion is set.

Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index f0b799764..20bca23c7 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -840,9 +840,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)
 			goto out;
 		}
+
+		if (!wait_to_complete || new.link_status)
+			break;
+
 		rte_delay_ms(BNXT_LINK_WAIT_INTERVAL);
-
-		if (!wait_to_complete)
-			break;
-	} while (!new.link_status && cnt--);
+	} while (cnt--);
 
 out:
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:34.144590677 +0100
+++ 0040-net-bnxt-fix-unconditional-wait-in-link-update.patch	2019-08-28 14:32:31.689956290 +0100
@@ -1 +1 @@
-From 0a44537589454a9aba3e9ad392218ad433fbf529 Mon Sep 17 00:00:00 2001
+From 052a49557654602d4a3567c81cb761813a6cf4c7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0a44537589454a9aba3e9ad392218ad433fbf529 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 15048de3f..55b030a2b 100644
+index f0b799764..20bca23c7 100644
@@ -22 +23 @@
-@@ -974,9 +974,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)
+@@ -840,9 +840,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)


More information about the stable mailing list