[dpdk-stable] patch 'net/bnxt: reset filters before registering interrupts' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Wed Aug 28 15:42:18 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/cab07f52210e5e74e13d528af330393110a6eb9a

Thanks.

Kevin Traynor

---
>From cab07f52210e5e74e13d528af330393110a6eb9a Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Thu, 18 Jul 2019 09:06:01 +0530
Subject: [PATCH] net/bnxt: reset filters before registering interrupts

[ upstream commit 161964c6dc70f01244e5e399a852d9dc10007caf ]

If interrupt registration fails during device init, driver invokes
uninit which in turn causes error messages while trying to free
vnic filters. Fix this by moving filter initialization call before
interrupt registration.

Fixes: 1b533790f44e ("net/bnxt: avoid invalid vnic id in set L2 Rx mask")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 15f2bdcf4..0bfa386aa 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3552,10 +3552,10 @@ skip_ext_stats:
 		goto error_free;
 
-	rc = bnxt_request_int(bp);
-	if (rc)
-		goto error_free;
-
 	bnxt_init_nic(bp);
 
+	rc = bnxt_request_int(bp);
+	if (rc)
+		goto error_free;
+
 	return 0;
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:34.333195858 +0100
+++ 0043-net-bnxt-reset-filters-before-registering-interrupts.patch	2019-08-28 14:32:31.701956023 +0100
@@ -1 +1 @@
-From 161964c6dc70f01244e5e399a852d9dc10007caf Mon Sep 17 00:00:00 2001
+From cab07f52210e5e74e13d528af330393110a6eb9a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 161964c6dc70f01244e5e399a852d9dc10007caf ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 4d1c9adb9..3368508df 100644
+index 15f2bdcf4..0bfa386aa 100644
@@ -25 +26 @@
-@@ -4026,10 +4026,10 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
+@@ -3552,10 +3552,10 @@ skip_ext_stats:


More information about the stable mailing list