[dpdk-stable] patch 'net/i40e: fix flow director rule destroy' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Wed Aug 28 15:42:33 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/f03e7709b780b3f25470596db9a66ccbb296302b

Thanks.

Kevin Traynor

---
>From f03e7709b780b3f25470596db9a66ccbb296302b Mon Sep 17 00:00:00 2001
From: Xiaolong Ye <xiaolong.ye at intel.com>
Date: Mon, 22 Jul 2019 20:06:38 +0800
Subject: [PATCH] net/i40e: fix flow director rule destroy

[ upstream commit 4fe1af80dd50bc44ac8ff2f395e8584f305b879c ]

We should tear down the fdir when the last flow is destroyed, current
logic is opposite to expected behavior, this patch fixes this issue.

Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")

Signed-off-by: Xiaolong Ye <xiaolong.ye at intel.com>
Acked-by: Beilei Xing <beilei.xing at intel.com>
---
 drivers/net/i40e/i40e_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 1699578ff..4208d8306 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4744,5 +4744,5 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
 
 		/* If the last flow is destroyed, disable fdir. */
-		if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
+		if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
 			i40e_fdir_teardown(pf);
 			dev->data->dev_conf.fdir_conf.mode =
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:35.260852884 +0100
+++ 0058-net-i40e-fix-flow-director-rule-destroy.patch	2019-08-28 14:32:31.739955175 +0100
@@ -1 +1 @@
-From 4fe1af80dd50bc44ac8ff2f395e8584f305b879c Mon Sep 17 00:00:00 2001
+From f03e7709b780b3f25470596db9a66ccbb296302b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4fe1af80dd50bc44ac8ff2f395e8584f305b879c ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 3c0af70c0..c60c9e240 100644
+index 1699578ff..4208d8306 100644
@@ -22 +23 @@
-@@ -4772,5 +4772,5 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
+@@ -4744,5 +4744,5 @@ i40e_flow_destroy(struct rte_eth_dev *dev,


More information about the stable mailing list