[dpdk-stable] patch 'net/sfc: fix missing notification on link status change' has been queued to LTS release 18.11.6

Kevin Traynor ktraynor at redhat.com
Tue Dec 3 19:26:11 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c0b4d8dac51ffd3d65d987fb2186a06dbcedb30b

Thanks.

Kevin.

---
>From c0b4d8dac51ffd3d65d987fb2186a06dbcedb30b Mon Sep 17 00:00:00 2001
From: Andrew Rybchenko <arybchenko at solarflare.com>
Date: Fri, 6 Sep 2019 11:49:49 +0100
Subject: [PATCH] net/sfc: fix missing notification on link status change

[ upstream commit 282b72cd725ac6f5a32558253ad80e905c3b4028 ]

rte_eth_linkstatus_set() returns 0 when link up status changes.

Fixes: 4abe903e5078 ("net/sfc: use link status helper functions")

Reported-by: Shuki Katzenelson <shuki at lightbitslabs.com>
Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 drivers/net/sfc/sfc_ev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
index f93d30e5c..bb98cba58 100644
--- a/drivers/net/sfc/sfc_ev.c
+++ b/drivers/net/sfc/sfc_ev.c
@@ -415,5 +415,5 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)
 
 	sfc_port_link_mode_to_info(link_mode, &new_link);
-	if (rte_eth_linkstatus_set(sa->eth_dev, &new_link))
+	if (rte_eth_linkstatus_set(sa->eth_dev, &new_link) == 0)
 		evq->sa->port.lsc_seq++;
 
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-03 17:29:51.921039318 +0000
+++ 0002-net-sfc-fix-missing-notification-on-link-status-chan.patch	2019-12-03 17:29:51.674751536 +0000
@@ -1 +1 @@
-From 282b72cd725ac6f5a32558253ad80e905c3b4028 Mon Sep 17 00:00:00 2001
+From c0b4d8dac51ffd3d65d987fb2186a06dbcedb30b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 282b72cd725ac6f5a32558253ad80e905c3b4028 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 0f216da5d..6a58a2d97 100644
+index f93d30e5c..bb98cba58 100644
@@ -21 +22 @@
-@@ -421,5 +421,5 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)
+@@ -415,5 +415,5 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)



More information about the stable mailing list