[dpdk-stable] patch 'net/ixgbe: fix link status' has been queued to LTS release 18.11.6

Kevin Traynor ktraynor at redhat.com
Wed Dec 11 22:25:58 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c904c37a6c43bab8f874706aefbbd5bc3a42a4a4

Thanks.

Kevin.

---
>From c904c37a6c43bab8f874706aefbbd5bc3a42a4a4 Mon Sep 17 00:00:00 2001
From: Xiao Zhang <xiao.zhang at intel.com>
Date: Tue, 29 Oct 2019 13:33:23 +0800
Subject: [PATCH] net/ixgbe: fix link status

[ upstream commit 1ca05831b9be946001ebabba2b3fdb0456684d9a ]

The link status for 82599eb got from link status register was not
correct, check the enable/disable flag of tx laser when getting the link
status, set the link status down if tx laser disabled since the tx laser
flag could be set correctly when up/down the link status.

Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")

Signed-off-by: Xiao Zhang <xiao.zhang at intel.com>
Reviewed-by: Wei Zhao <wei.zhao1 at intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3d4e62b5a..d099bc120 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2944,4 +2944,5 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev)
 		/* Turn on the laser */
 		ixgbe_enable_tx_laser(hw);
+		ixgbe_dev_link_update(dev, 0);
 	}
 
@@ -2974,4 +2975,5 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev)
 		/* Turn off the laser */
 		ixgbe_disable_tx_laser(hw);
+		ixgbe_dev_link_update(dev, 0);
 	}
 
@@ -4087,4 +4089,5 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 	int diag;
 	int wait = 1;
+	u32 esdp_reg;
 
 	memset(&link, 0, sizeof(link));
@@ -4114,4 +4117,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 	}
 
+	esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);
+	if ((esdp_reg & IXGBE_ESDP_SDP3))
+		link_up = 0;
+
 	if (link_up == 0) {
 		if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-11 21:24:13.261655241 +0000
+++ 0006-net-ixgbe-fix-link-status.patch	2019-12-11 21:24:12.579653036 +0000
@@ -1 +1 @@
-From 1ca05831b9be946001ebabba2b3fdb0456684d9a Mon Sep 17 00:00:00 2001
+From c904c37a6c43bab8f874706aefbbd5bc3a42a4a4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1ca05831b9be946001ebabba2b3fdb0456684d9a ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 9c386f5c9..30c0379d4 100644
+index 3d4e62b5a..d099bc120 100644
@@ -25 +26 @@
-@@ -2913,4 +2913,5 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev)
+@@ -2944,4 +2944,5 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev)
@@ -31 +32 @@
-@@ -2943,4 +2944,5 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev)
+@@ -2974,4 +2975,5 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev)
@@ -37 +38 @@
-@@ -4117,4 +4119,5 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+@@ -4087,4 +4089,5 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
@@ -43 +44 @@
-@@ -4144,4 +4147,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+@@ -4114,4 +4117,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,



More information about the stable mailing list